Dockerfile: cross compile images using native builder #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnorris
force-pushed
the
will/crosscompile
branch
3 times, most recently
from
ee834fc to
a342bb0
Compare
DentonGentry
approved these changes
Jan 10, 2023
Dockerfile
Outdated
| RUN CGO_ENABLED=0 GOOS=linux go build -v ./cmd/golink | ||
| ARG TARGETOS TARGETARCH TARGETVARIANT | ||
| RUN \ | ||
| if [ "${TARGETARCH}" = "arm" ] && [ "${TARGETVARIANT}" ]; then \ |
There was a problem hiding this comment.
I'd usually expect to see a shell -z test in cases like this:
if ... && [ -z "${TARGETVARIANT}" ]; then
There was a problem hiding this comment.
ah, yes. -n in this case, but done.
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
willnorris
force-pushed
the
will/crosscompile
branch
from
a342bb0 to
f671da3
Compare
DentonGentry
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a build image built for the native architecture so that it doesn't run in emulation mode.
This also allows us to switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs.
Recently our build times have been up to 20 minutes; this brings them back down to about 3 minutes.
(cc @amouat as FYI)
Updates #42
Updates #43