Dockerfile: use musl variant for go build image #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42 Signed-off-by: Will Norris <[email protected]>
DentonGentry
approved these changes
Jan 7, 2023
|
It's worth noting also that I don't think this should really be necessary long term. Because Go has such good cross-compilation support, we should be able to build an arm/v7 binary on an amd64 or arm64 build image. I'll just have to figure out how to configure the build step to make sure those all get tagged properly and such. This post has more details: https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ |
willnorris
added a commit
that referenced
this pull request
Jan 10, 2023
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Jan 10, 2023
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Jan 10, 2023
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Jan 10, 2023
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Jan 10, 2023
Use a build image built for the native architecture so that it doesn't run in emulation mode. Switch to Chainguard's wolfi/glibc build image. This limits our build architectures to just amd64 and arm64, but that is sufficient for our needs. Updates #42 Updates #43 Signed-off-by: Will Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the details are in chainguard-images/images#182. At the end of last year, Chainguard switched from alpine+musl to wolfi+glibc as their default for their go images. These new images are only built for linux/amd64 and linux/arm64. We'd build for linux/arm/v7 as well in order to support older raspberry pis, which is only available in the musl images.
Fixes #42