Added canPrePopulate() method. Fixes #87 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure who is maintaining this repo. Are you happy for me to go ahead and merge? |
|
Everything is maintained by @nitriques these days. Not sure about merging yourself as I don’t know about Nicolas’ release workflow. |
|
@pointybeard Hi! Thanks for the PR! @brendo yeah, @jensscherbl's is right. Please request a review instead! |
|
It's been released as 2.0.2 |
|
No problems! Thanks for the speedy release. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #87 and symphonycms/symphonycms#2751
Prior to this change in 2.7.x, the Publish: New page never actually checked to see if a field was allowed to prepopulate. The SBL field was missing the
canPrePopulatemethod, so meant prepopulating stopped working.This PR added that method in, bringing SBL field up to date with new behaviour in 2.7.x.