Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepopulating no longer working with latest 2.7.x Symphony branch #87

Closed
pointybeard opened this issue Oct 2, 2017 · 0 comments
Closed
Assignees
Labels

Comments

@pointybeard
Copy link
Member

There was a change recently that meant prepopulating values in Select Box Link fields isn't working. You can see the issue at symphonycms/symphonycms#2751

The problem is SBL field is missing a canPrePopulate() method. It appears that it should have had one, but worked due to a missing check in the __viewNew method of contentPublish class.

The solution is to simply add the following to the SBL field (since the parent object returnsfalse):

    public function canPrePopulate() {
        return true;
    }

Doesn't appear to be any side effects to this addition since the field has always been able to prepopulate.

I will make a pull request for this change shortly.

@pointybeard pointybeard added the bug label Oct 2, 2017
@pointybeard pointybeard self-assigned this Oct 2, 2017
@brendo brendo closed this as completed in 86cdb67 Oct 3, 2017
brendo added a commit that referenced this issue Oct 3, 2017
Added canPrePopulate() method. Fixes #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant