New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum CMake version to 3.16 #732

Merged

danthony06 merged 1 commit into swri-robotics:master from daniel-dsouza:master

May 30, 2024

daniel-dsouza commented May 30, 2024 •

edited

Loading

When building with newer (CMake 3.28), the following warning will appear.

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

This PR increases minimum CMake version to 3.16 to satisfy the compatibility check in newer CMake versions.

Note that Ubuntu focal (ROS Noetic) packages CMake 3.16.3, so this will be incompatible with the EOL ROS Melodic.


          Increase minimum CMake version to 3.16 to satisfy the compatiblity ch…

ab3ecb7

…eck in newer CMake versions

Contributor

danthony06 commented May 30, 2024

Thanks. I made a branch called melodic-eol before merging this since it is a breaking change.

danthony06 merged commit 400bcdf into swri-robotics:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet