Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension compiler pass #2

Closed
wants to merge 5 commits into from

Conversation

Taluu
Copy link

@Taluu Taluu commented Apr 24, 2014

Move all related stuff to DIC configuration into compilers ; basically, here what was done :

  • Ensured that a broker (or channel_factory ? There are some naming issue I guess) can be declared as one if it has a swarrot.broker tag. This name can be modified though (swarrot.channel_factory ?)
  • Ensured that a channel_factory implements the FactoryInterface
  • Ensured that the PECL factory is not the only one used when building commands

That is more or less a POC, even though I added some tests.

(Related to #1)

@Taluu
Copy link
Author

Taluu commented Apr 29, 2014

After several rebases and tests, I think this should do the trick. Poke @odolbeau.

@odolbeau
Copy link
Member

As I said before, for now it's more a POC than a fully working version.

I think adding a CompilerPass for providers is a bit overkill for now.
For commands, why not, but before that, I would like to have a working and flexible version.

I think I will push to prod a sf2 worker with this bundle today or maybe tomorrow morning. After that, I will work on a way to configure easily which processors should be used for each consumers. :)

I hope I will be able to relase a first version before the end of the week. :)

@Taluu
Copy link
Author

Taluu commented Apr 29, 2014

I wasd thinking that the ConsumerCommand Pass was a bit overkill rather than the ProviderPass. the ProviderPass is useful to allow any type of factory (even when we want to create another factory that is not registered and acknowledged within the bundle), because a tag is involved, which make it way easier to create a new factory.

Actually, the bundle is limiting the possibilities as this is hard coded into the configuration tree...

@Taluu Taluu closed this Jun 3, 2014
@Taluu Taluu deleted the extension-compiler-pass branch June 3, 2014 10:57
@Taluu Taluu mentioned this pull request Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants