Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CompilerPass rather than Extension #1

Closed
Taluu opened this issue Apr 24, 2014 · 2 comments
Closed

Use CompilerPass rather than Extension #1

Taluu opened this issue Apr 24, 2014 · 2 comments

Comments

@Taluu
Copy link

Taluu commented Apr 24, 2014

i don't know if it is only a personnal POV, but I think that manipulating the container in the Extension configuration is not a really good practice ; I think it should be manipulated within a compiler pass.

I'll try to do a PR as soon as I can, if the idea is acknowledged. :)

@odolbeau
Copy link
Member

For now it's just a POC. :)
I just want to have a working worker in our environment before making something better than this POC. :)

@stof
Copy link
Contributor

stof commented May 13, 2014

Building services of the bundle based on the config is precisely the goal of an extension class. It is absolutely not a bad practice (otherwise all Symfony core bundles would be full of such bad practice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants