You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i don't know if it is only a personnal POV, but I think that manipulating the container in the Extension configuration is not a really good practice ; I think it should be manipulated within a compiler pass.
I'll try to do a PR as soon as I can, if the idea is acknowledged. :)
The text was updated successfully, but these errors were encountered:
Building services of the bundle based on the config is precisely the goal of an extension class. It is absolutely not a bad practice (otherwise all Symfony core bundles would be full of such bad practice)
i don't know if it is only a personnal POV, but I think that manipulating the container in the Extension configuration is not a really good practice ; I think it should be manipulated within a compiler pass.
I'll try to do a PR as soon as I can, if the idea is acknowledged. :)
The text was updated successfully, but these errors were encountered: