Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] Fix missing dependencies in Scala API client pom.xml #5092

Merged
merged 2 commits into from
Mar 18, 2017

Conversation

ePaul
Copy link
Contributor

@ePaul ePaul commented Mar 16, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change.
    → bin/scala-petstore.sh
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

I noticed that my merge of master and 2.3.0 had a different version number than both master and 2.3.0.
The reason is that the master sample was not up-to-date (#4881 forgot to update the scala samples).

@ePaul
Copy link
Contributor Author

ePaul commented Mar 16, 2017

As predicted, Travis breaks:

INFO] --- scala-maven-plugin:3.1.5:compile (scala-compile-first) @ swagger-scala-client ---
[INFO] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/scala/src/main/scala:-1: info: compiling
[INFO] Compiling 10 source files to /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/scala/target/classes at 1489682820931
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/scala/src/main/scala/io/swagger/client/ApiInvoker.scala:34: error: object datatype is not a member of package com.fasterxml.jackson
[ERROR] import com.fasterxml.jackson.datatype.joda.JodaModule
[ERROR]                              ^
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/scala/src/main/scala/io/swagger/client/ApiInvoker.scala:44: error: not found: type JodaModule
[ERROR]     mapper.registerModule(new JodaModule());
[ERROR]                               ^
[ERROR] two errors found

I'll add the missing dependency directly to the pom.mustache.

@wing328 wing328 added this to the v2.2.3 milestone Mar 18, 2017
@wing328 wing328 merged commit 1b973d2 into swagger-api:master Mar 18, 2017
@wing328 wing328 changed the title Update petstore samples for scala client. [Scala] Fix missing dependencies in Scala API client pom.xml Mar 18, 2017
@ePaul ePaul deleted the update-scala-client-samples branch March 18, 2017 09:00
pgrm added a commit to apaleo/swagger-codegen that referenced this pull request Mar 19, 2017
* [Swift] Detect file type in Swift codegen

* Fix Issue swagger-api#5063 (deleting wrong sample files) (swagger-api#5064)

* Update samples for springboot, spring-delegate, spring-delegate-j8.

* Issue swagger-api#5063: delete samples in the correct directory.

* fix link to Cummins

* Update wordnik.yaml

* Update wordnik.yaml

* add https://github.com/christopheradams/elixir_style_guide

* add https://github.com/inaka/erlang_guidelines

* [Haskell] Fix broken client/server compilation errors (swagger-api#5097)

* Remove dead legacy code

* Update cosmetics according to Haskell standard practices

* Fix failing pattern matching for lookupEither

* Bump to latest dependencies without any breaking changes

* Remove duplicate instance declarations already existing in Servant.API.Verbs

* Fix double Java/Haskell escapement bug

* Re-generate Petstore sample client/server

* Add Selective Generation support to the Maven plugin. (swagger-api#5036)

* Updated maven plugin to allow for selective generation

* Documentation of Selective generation options.

* Update petstore samples for scala client. (swagger-api#5092)

* Update petstore samples for scala client.

* Fix missing dependency problem.

* Fix sample script to set the correct artifact ID in the generated POM (swagger-api#5094)

* Update samples for akka.

* Have akka-scala-petstore scripts set the correct artifact names

* Update akka-scala samples again.

* Update samples for C#/SwaggerClientWithPropertyChanged. (swagger-api#5095)

* Swift3 enum: number variable names fix (swagger-api#5060)

* Swift3 enum: number variable names fix

Swift3 generator: added 'number' prefix to enum variable names that start with a number

* Fixed Swift3 enum variable names starting with number (prefixed with '_') and added test cases

* Swift3 enum var names: made sure to keep the next word after a number in lower case

* add jackson dependencies to pom for cxf-client swagger-api#4924 (swagger-api#5032)

* add petstore sample for jaxrs-cxf-client, update travis ci (swagger-api#5111)

* fix path with {{{ .. }}} in c# api mustache file (swagger-api#5112)

* Updated feign library to use latest version of OpenFeign and Jackson. (swagger-api#5114)
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
* Update petstore samples for scala client.

* Fix missing dependency problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants