Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooling] bin/spring-delegate.sh and bin/spring-delegate-j8.sh delete sample files in springboot directory #5063

Closed
ePaul opened this issue Mar 14, 2017 · 1 comment

Comments

@ePaul
Copy link
Contributor

ePaul commented Mar 14, 2017

Description

Running the shell scripts bin/spring-delegate.sh or bin/spring-delegate-j8.sh deletes sample files in samples/server/petstore/springboot, which were not created by the same script, but by bin/springboot-petstore-server.sh.

Depending on the order of execution, you can end up with pom.xml and .swagger-codegen-ignore missing.

Swagger-codegen version

Happens with current master, I didn't check how much back.

Steps to reproduce

From the main directory, run bin/spring-delegate.sh, (or bin/spring-delegate-j8.sh) then git status. Some files are missing.

Suggest a Fix

I'll submit a pull request.

ePaul added a commit to ePaul/swagger-codegen that referenced this issue Mar 14, 2017
wing328 pushed a commit that referenced this issue Mar 15, 2017
* Update samples for springboot, spring-delegate, spring-delegate-j8.

* Issue #5063: delete samples in the correct directory.
@ePaul
Copy link
Contributor Author

ePaul commented Mar 15, 2017

Merged #5064.

@ePaul ePaul closed this as completed Mar 15, 2017
pgrm added a commit to apaleo/swagger-codegen that referenced this issue Mar 19, 2017
* [Swift] Detect file type in Swift codegen

* Fix Issue swagger-api#5063 (deleting wrong sample files) (swagger-api#5064)

* Update samples for springboot, spring-delegate, spring-delegate-j8.

* Issue swagger-api#5063: delete samples in the correct directory.

* fix link to Cummins

* Update wordnik.yaml

* Update wordnik.yaml

* add https://github.com/christopheradams/elixir_style_guide

* add https://github.com/inaka/erlang_guidelines

* [Haskell] Fix broken client/server compilation errors (swagger-api#5097)

* Remove dead legacy code

* Update cosmetics according to Haskell standard practices

* Fix failing pattern matching for lookupEither

* Bump to latest dependencies without any breaking changes

* Remove duplicate instance declarations already existing in Servant.API.Verbs

* Fix double Java/Haskell escapement bug

* Re-generate Petstore sample client/server

* Add Selective Generation support to the Maven plugin. (swagger-api#5036)

* Updated maven plugin to allow for selective generation

* Documentation of Selective generation options.

* Update petstore samples for scala client. (swagger-api#5092)

* Update petstore samples for scala client.

* Fix missing dependency problem.

* Fix sample script to set the correct artifact ID in the generated POM (swagger-api#5094)

* Update samples for akka.

* Have akka-scala-petstore scripts set the correct artifact names

* Update akka-scala samples again.

* Update samples for C#/SwaggerClientWithPropertyChanged. (swagger-api#5095)

* Swift3 enum: number variable names fix (swagger-api#5060)

* Swift3 enum: number variable names fix

Swift3 generator: added 'number' prefix to enum variable names that start with a number

* Fixed Swift3 enum variable names starting with number (prefixed with '_') and added test cases

* Swift3 enum var names: made sure to keep the next word after a number in lower case

* add jackson dependencies to pom for cxf-client swagger-api#4924 (swagger-api#5032)

* add petstore sample for jaxrs-cxf-client, update travis ci (swagger-api#5111)

* fix path with {{{ .. }}} in c# api mustache file (swagger-api#5112)

* Updated feign library to use latest version of OpenFeign and Jackson. (swagger-api#5114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant