Default info on SVGO.optimize API
#1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2019
|
Thanks for the quick turnaround all! My build system took a break for the day while I waited anxiously for this to be merged 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR #1173, and commit 71c7fe7, passing
infoto theSVGO.optimizefunction is no longer optional. Without settinginfo, the following error is thrown:Cannot set property 'multipassCount' of undefinedI'm not entirely sure if this was ever meant to be optional, but, it's worked that way up until 1.3.0, and you can find hundreds of examples on GitHub of people using it this way: https://github.com/search?l=JavaScript&q=%22svgo.optimize%22&type=Code
This PR simply sets
infoto an empty object if it's not set, which enables backwards compatibility with 1.3.0 and other versions, which will save people who use "compatible with" versions in their package.json declarations. If you have a better suggestion for how to solve this, I'm open to it.Fixes #1174