Add multipassCount to info object; skip subsequent passes in prefixIds plugin #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use info object to skip subsequent passes in prefixIds plugin to prevent unintended, multiple prefixing.
strarsis
changed the title
This was referenced Oct 29, 2019
|
released in v1.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
multipassCountto theinfoobject that is passed to the plugins.This allows plugins to know whether they already processed a SVG node/document and how many times. This is necessary for the
prefixIdsplugin to skip in subsequent passes when multipass is used to prevent unintended, multiple prefixing (see #1148).The
infoobject is perfectly suited for this kind of extra/runtime information for the plugins,and it is already used by
prefixIdsplugin for obtaining the path of the SVG (node) it is processing.