Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null values in jwtPayload and sessionData more gracefully #77

Closed
rishabhpoddar opened this issue Jan 30, 2021 · 2 comments
Closed

Handle null values in jwtPayload and sessionData more gracefully #77

rishabhpoddar opened this issue Jan 30, 2021 · 2 comments
Assignees
@bhumilsarvaiya

Comments

@rishabhpoddar
Copy link
Contributor

rishabhpoddar commented Jan 30, 2021 •
edited
Loading

Allow the user to give null in createNewSession and other functions that update session payloads. We can handle this by checking for null and setting it to undefined instead.
@bhumilsarvaiya
Copy link
Contributor

@rishabhpoddar should it be undefined or {} (which is also the default value if user has not passed any value)?

@rishabhpoddar
Copy link
Contributor Author

{} should be fine.

bhumilsarvaiya added a commit that referenced this issue Feb 2, 2021
@bhumilsarvaiya
fixes #77
9fd95a6
@rishabhpoddar rishabhpoddar mentioned this issue Feb 2, 2021
Merged
rishabhpoddar added a commit that referenced this issue Feb 4, 2021
@bhumilsarvaiya @rishabhpoddar
config input schema validation added and checking for null with sessi…
86f67d2 
…on and jwt data (#81)

* config input schema validation added. closes #73

* fixes #77

* code review changes

* fixes review comments

Co-authored-by: Rishabh Poddar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhumilsarvaiya bhumilsarvaiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rishabhpoddar @bhumilsarvaiya