Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist all config params for easier implementation #73

Closed
rishabhpoddar opened this issue Jan 25, 2021 · 0 comments
Closed

Whitelist all config params for easier implementation #73

rishabhpoddar opened this issue Jan 25, 2021 · 0 comments
Assignees
@bhumilsarvaiya

Comments

@rishabhpoddar
Copy link
Contributor

For each config and sub config in the init function, we must check against that whitelist for that config / sub config. If the current item is not in the whitelist, then we must throw an error.
bhumilsarvaiya added a commit that referenced this issue Feb 2, 2021
@bhumilsarvaiya
config input schema validation added. closes #73
c916737
@rishabhpoddar rishabhpoddar mentioned this issue Feb 2, 2021
Merged
rishabhpoddar added a commit that referenced this issue Feb 4, 2021
@bhumilsarvaiya @rishabhpoddar
config input schema validation added and checking for null with sessi…
86f67d2 
…on and jwt data (#81)

* config input schema validation added. closes #73

* fixes #77

* code review changes

* fixes review comments

Co-authored-by: Rishabh Poddar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhumilsarvaiya bhumilsarvaiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rishabhpoddar @bhumilsarvaiya