fix: exports ApiError interface so can be used by third-party implementations #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
When upgrading to the latest supabase-js (and hence gotrue-js) sdks for RedwoodJS, ran into the case where:
Now the client returns GoTrueApi's
ApiError
can not just anError
.But, it didn't see that
ApiError
was exported to allow a change in all the auth methods from, for example:To use
error: ApiError | null
To match:
What is the current behavior?
ApiError is not exported as a type.
What is the new behavior?
Additional context
Since both GoTrueClient and GoTrueApi need
ApiError
I figured it was ok to move that into types.but if there is a better place for it, let me know.
I didn't want to export it from GoTrueApi and import that in GoTrueClient.
For the PR that introduced APiError, see: https://github.com/supabase/gotrue-js/pull/137/files