[v1.0.0-rc] Remove deprecated features #2896

callingmedic911 · 2021-06-26T08:03:02Z

Closes #2631.

Before merging, maybe we want recheck:

If we have any more deprecated features to remove.
EDIT 29th Sept 21:
- ~~beforeResolver is deprecated in v0.37.~~ Already removed
If we need anything from 15fdd40. Applied again.
~~Update docs~~ Not required anymore.

This removes deprecated features planned for v1-rc.

Form changes moved to Upgrade RHF to v7.11.0 #3043
Moved non-critical changes to Remove deprecated non-critical features #3088
Reverted form changes commits, reverted api-server deprecation. Kept revert commits.
Removed flash component deprecated, it's already been removed in Add helmet to web for meta tags | Prerender support #2909

Original:
I removed everything that says deprecated, even if it was marked deprecated only a few weeks ago. For example: 56f6019 (Supabase data field)
Also, I made sure one commits maps to individual features, so it's a bit easier to review commit-wise and revert.

The only deprecated annotation left is - processPagesDir(), which we can remove once we have the suggested alternate implementation.

@dac09 @jtoar @thedavidprice

thedavidprice · 2021-07-07T01:30:03Z

Thank for getting this going @callingmedic911

@dac09 @peterp When do you think the timing is right for this one? Maybe v0.36, which will be within a couple of releases of v1-rc?

thedavidprice · 2021-07-20T23:29:57Z

Hi @callingmedic911 Thank you for your patience with us on this one. I had a discussion with the core team maintainers, and we would like to handle this is two parts:

deprecate some non-critical features now or in any other releases leading up to v1.0.0-rc.0
wait for "critical" deprecations until the release of v1.0.0-rc.0

Our thinking it that we don't want to create much resistance to people upgrading now.

To Deprecate Now

For deprecations to include in our next release, I suggest:

fully deprecating the obsolete commands, so any files in packages/cli/src/commands/* included in this PR. Note: we'll need to update the CLI documentation as well.
the Forms package deprecations packages/core/src/index.ts and packages/forms/src/index.tsx
- it feels more appropriate to make those changes in this PR upgrading React Hook Forms Upgrade RHF to v7.11.0 #3043
- could you coordinate with @LBrian and @jtoar for a plan?

To deprecate with v1.0.0-rc.0

Then the remaining deprecation should happen along with the v1-rc release (along with anything else new that's scheduled for deprecation).

What do you think of this plan? If it makes sense, just let me know how you want to split the PRs. Maybe just create a new PR for the commands deprecation and then pull the changes into this PR? Loop me in however needed.

LBrian · 2021-07-21T00:25:47Z

could you coordinate with @LBrian and @jtoar for a plan?

@thedavidprice I had a quick look of this PR, agreed and makes sense we should cherry-pick form changes into #3043 for sure, I will do that later today. @callingmedic911 I will keep you in the loop.

it feels more appropriate to make those changes in this PR upgrading React Hook Forms [Error while deploying web side with prerender through Serverles [update fixed!]

Btw, just a kind reminding you might accidentally pasted the wrong PR number, just pointed out in case others get confused. :)

thedavidprice · 2021-07-21T00:50:16Z

@LBrian gah, fixed! (thank you... numbers are hard sometimes.)

callingmedic911 · 2021-07-21T06:03:28Z

Our thinking it that we don't want to create much resistance to people upgrading now.

Totally agree.

fully deprecating the obsolete commands, so any files in packages/cli/src/commands/* included in this PR. Note: we'll need to update the CLI documentation as well.

I guess this also includes api-server CLI command? I'll create a separate PR and cherry-pick commands deprecation.

the Forms package deprecations packages/core/src/index.ts and packages/forms/src/index.tsx

it feels more appropriate to make those changes in this PR upgrading React Hook Forms Upgrade RHF to v7.11.0 #3043

could you coordinate with @LBrian and @jtoar for a plan?

I see @LBrian has cherry-picked 502159a and ff10aee. Thanks a lot @LBrian. :) I'll remove these commit from this PR now.
By the way, @thedavidprice also mentioned packages/core/src/index.ts, do we want to cherry-pick fd9a590? I don't think it's related to forms.

Then the remaining deprecation should happen along with the v1-rc release (along with anything else new that's scheduled for deprecation).

What do you think of this plan? If it makes sense, just let me know how you want to split the PRs. Maybe just create a new PR for the commands deprecation and then pull the changes into this PR? Loop me in however needed.

Sounds good! I'll use new commands deprecation branch as head for this one and we can merge remaining changes in v1-rc.

thedavidprice · 2021-07-21T06:25:51Z

I guess this also includes api-server CLI command?

Ah, I forgot to mention that we should skip anything api-server related for now. Peter has changes coming, so let's wait for those.

By the way, @thedavidprice also mentioned packages/core/src/index.ts, do we want to cherry-pick fd9a590? I don't think it's related to forms

My mistake. I didn't mean to include that file. Let's skip for now 🤦‍♂️

Thanks!

callingmedic911 · 2021-07-21T06:27:05Z

Got it. Thank you!

This reverts commit 15fdd40.

This reverts commit 8c8f640.

This reverts commit 9e2c4ea.

thedavidprice

Looping in others for specific questions.

Redwood-tools

I think it's time to fully deprecate redwood-tools.js

packages/cli/src/redwood-tools.js
references to redwood-tools and rwt in packages/cli
- including references in packages/cli/README.md

Agreed @dac09?

REDWOODAPI_PROXY_PATH

Looks like we still have a reference to remove over here:

packages/web/src/global.web-auto-imports.ts

Supabase.ts

@dthyresson do you have suggestions about how/if we should handle deprecations in:

packages/auth/src/authClients/supabase.ts

?

Scaffold.js

@cannikin any reason not to fully deprecate this in v0.39?

redwood/packages/cli/src/commands/generate/scaffold/scaffold.js

Lines 692 to 697 in f129c58

    
           /** @deprecated Used to be able to create dbAuth pages with `yarn rw g scaffold dbAuth` */ 
        
           if (modelArg.toLowerCase() === 'dbauth') { 
        
             console.info(c.green('\nGenerate dbAuth pages with:\n')) 
        
             console.info('  yarn rw generate dbAuth\n') 
        
             process.exit(0) 
        
           }

processPagesDir

@peterp @dac09 Is this still an intended deprecation?

redwood/packages/internal/src/paths.ts

Lines 218 to 227 in f129c58

    
           /** 
        
            * Process the pages directory and return information useful for automated imports. 
        
            * 
        
            * Note: glob.sync returns posix style paths on Windows machines 
        
            * @deprecated I will write a seperate method that use `getFiles` instead. This 
        
            * is used by structure, babel auto-importer and the eslint plugin. 
        
            */ 
        
           export const processPagesDir = ( 
        
             webPagesDir: string = getPaths().web.pages 
        
           ): Array<PagesDependency> => {

cannikin · 2021-11-10T00:25:53Z

@cannikin any reason not to fully deprecate this in v0.39?

Nope, go ahead and remove! I updated the docs recently to reference the new command yarn rw g dbAuth so we should be safe to remove.

callingmedic911 · 2021-11-10T04:14:59Z

Thanks for reviewing thoroughly @thedavidprice!

__REDWOOD__API_PROXY_PATH: Looks like we still have a reference to remove over here:

packages/web/src/global.web-auto-imports.ts

I'm not able to find any references to __REDWOOD__API_PROXY_PATH, am I missing something here?

Apart from this, I have removed dbAuth deprecation warning in the scaffold. Waiting for confirmation from others, then if required will those as well.

dthyresson · 2021-11-15T15:37:20Z

@thedavidprice for

Supabase.ts

@dthyresson do you have suggestions about how/if we should handle deprecations in:

packages/auth/src/authClients/supabase.ts

I assume this question refers to:

  }): Promise<{
    user: User | null
    session: Session | null
    error: Error | null
    data: Session | User | null // Deprecated
  }>

to data.

I'll check as that may no longer be in the current Supabase js sdk.

dthyresson · 2021-11-15T16:22:23Z

FYI for Supabase, can upgrade to latest and then remove deprecations, but relies on a fix: supabase/auth-js#178

dthyresson · 2021-11-19T13:56:48Z

FYI for Supabase, can upgrade to latest and then remove deprecations, but relies on a fix: supabase/gotrue-js#178

supabase/auth-js#179 has been merged, just need to await the next supabase-js release which I believe well be next week.

jtoar · 2021-11-19T21:05:30Z

@thedavidprice processPagesDir looks like something we can remove at any time in the RC process since it's internal. It's used in the structure package and a babel plugin (for auto-loading the routes in Routes.js) so it we also can't remove it without an alternative.

thedavidprice · 2021-11-19T21:54:34Z

Finalizing and merging this now.

Moved Supabase deprecation step to #3756

Release Notes: Breaking

Router Globals

Fully deprecates:

__REDWOOD__API_URL
__REDWOOD__API_GRAPHQL_SERVER_PATH
__REDWOOD__API_PROXY_PATH

Use the following instead:

RWJS_API_GRAPHQL_URL
RWJS_API_DBAUTH_URL
RWJS_API_URL

callingmedic911 added 2 commits June 24, 2021 23:56

Remove schemaDirectives from makeMergedSchema

7640cdd

Remove deprecated api-server command

15fdd40

callingmedic911 marked this pull request as draft June 26, 2021 08:13

callingmedic911 force-pushed the remove-deprecated-features branch from a3c1eac to ff10aee Compare June 26, 2021 08:20

callingmedic911 marked this pull request as ready for review June 26, 2021 08:42

thedavidprice added the v1/priority label Jul 7, 2021

thedavidprice self-assigned this Jul 7, 2021

thedavidprice changed the title ~~Remove deprecated features~~ [v1.0.0-rc] Remove deprecated features Jul 20, 2021

thedavidprice added this to the future-release milestone Jul 20, 2021

LBrian mentioned this pull request Jul 21, 2021

Upgrade RHF to v7.11.0 #3043

Merged

callingmedic911 mentioned this pull request Jul 21, 2021

Remove deprecated non-critical features #3088

Merged

3 tasks

callingmedic911 added 2 commits July 21, 2021 12:34

Remove deprecated getConfig

b1c102e

Remove deprecated prop dataType from form

8c8f640

callingmedic911 force-pushed the remove-deprecated-features branch from 8cafbf5 to f9b4738 Compare July 21, 2021 07:09

callingmedic911 added 5 commits July 21, 2021 12:51

Remove deprecated data field in supabase client

406e39d

Use transformValue instead of dataType in scaffold form

a23f334

Revert "Remove deprecated api-server command"

c49fbac

This reverts commit 15fdd40.

Revert "Remove deprecated prop dataType from form"

4df7f8e

This reverts commit 8c8f640.

Revert "Use transformValue instead of dataType in scaffold form"

3a1ed4f

This reverts commit 9e2c4ea.

callingmedic911 force-pushed the remove-deprecated-features branch from f9b4738 to 3a1ed4f Compare July 21, 2021 07:28

thedavidprice requested changes Nov 10, 2021

View reviewed changes

thedavidprice requested review from cannikin and dthyresson November 10, 2021 00:19

callingmedic911 added 2 commits November 10, 2021 09:29

Merge branch 'main' into remove-deprecated-features

7440a26

Remove deprecation warning for dbAuth scaffold

9c9327e

Merge branch 'main' into remove-deprecated-features

c9413d0

thedavidprice mentioned this pull request Nov 19, 2021

Update Auth templates for CurrentUser types and JWT/Error imports #3713

Merged

redwoodjsbot and others added 3 commits November 19, 2021 12:42

rm redwood tools

f9270b5

Merge branch 'main' into remove-deprecated-features

5aea77c

style: add back comment

73ff6ac

thedavidprice mentioned this pull request Nov 19, 2021

deprecate data in authClients/supabase.ts #3756

Closed

2 tasks

thedavidprice added the release:breaking This PR is a breaking change label Nov 19, 2021

Merge branch 'main' into remove-deprecated-features

01fc42f

thedavidprice added next-release/code-mod labels Nov 19, 2021

thedavidprice merged commit 44082ed into redwoodjs:main Nov 19, 2021

redwoodjs-bot bot modified the milestones: next-release-priority, next-release Nov 19, 2021

callingmedic911 deleted the remove-deprecated-features branch November 20, 2021 10:11

thedavidprice modified the milestones: next-release, v0.39.0 Nov 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.0.0-rc] Remove deprecated features #2896

[v1.0.0-rc] Remove deprecated features #2896

callingmedic911 commented Jun 26, 2021 •

edited

Loading

thedavidprice commented Jul 7, 2021

thedavidprice commented Jul 20, 2021 •

edited

Loading

LBrian commented Jul 21, 2021 •

edited by thedavidprice

Loading

thedavidprice commented Jul 21, 2021

callingmedic911 commented Jul 21, 2021 •

edited

Loading

thedavidprice commented Jul 21, 2021

callingmedic911 commented Jul 21, 2021

thedavidprice left a comment

cannikin commented Nov 10, 2021

callingmedic911 commented Nov 10, 2021

dthyresson commented Nov 15, 2021

dthyresson commented Nov 15, 2021

dthyresson commented Nov 19, 2021

jtoar commented Nov 19, 2021

thedavidprice commented Nov 19, 2021

	/** @deprecated Used to be able to create dbAuth pages with `yarn rw g scaffold dbAuth` */
	if (modelArg.toLowerCase() === 'dbauth') {
	console.info(c.green('\nGenerate dbAuth pages with:\n'))
	console.info(' yarn rw generate dbAuth\n')
	process.exit(0)
	}

	/**
	* Process the pages directory and return information useful for automated imports.
	*
	* Note: glob.sync returns posix style paths on Windows machines
	* @deprecated I will write a seperate method that use `getFiles` instead. This
	* is used by structure, babel auto-importer and the eslint plugin.
	*/
	export const processPagesDir = (
	webPagesDir: string = getPaths().web.pages
	): Array<PagesDependency> => {

[v1.0.0-rc] Remove deprecated features #2896

[v1.0.0-rc] Remove deprecated features #2896

Conversation

callingmedic911 commented Jun 26, 2021 • edited Loading

thedavidprice commented Jul 7, 2021

thedavidprice commented Jul 20, 2021 • edited Loading

To Deprecate Now

To deprecate with v1.0.0-rc.0

LBrian commented Jul 21, 2021 • edited by thedavidprice Loading

thedavidprice commented Jul 21, 2021

callingmedic911 commented Jul 21, 2021 • edited Loading

thedavidprice commented Jul 21, 2021

callingmedic911 commented Jul 21, 2021

thedavidprice left a comment

Choose a reason for hiding this comment

Redwood-tools

__REDWOOD__API_PROXY_PATH

Supabase.ts

Scaffold.js

processPagesDir

cannikin commented Nov 10, 2021

callingmedic911 commented Nov 10, 2021

dthyresson commented Nov 15, 2021

dthyresson commented Nov 15, 2021

dthyresson commented Nov 19, 2021

jtoar commented Nov 19, 2021

thedavidprice commented Nov 19, 2021

Release Notes: Breaking

Router Globals

callingmedic911 commented Jun 26, 2021 •

edited

Loading

thedavidprice commented Jul 20, 2021 •

edited

Loading

LBrian commented Jul 21, 2021 •

edited by thedavidprice

Loading

callingmedic911 commented Jul 21, 2021 •

edited

Loading

REDWOODAPI_PROXY_PATH