-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Savon WSDL client for WOS SOAP API #222
Conversation
b9b7cdf
to
f2c2edd
Compare
f575ff6
to
adc47da
Compare
1eb712a
to
7c06735
Compare
abc9bed
to
7c543a4
Compare
e1afc05
to
81b9e53
Compare
8d2fe03
to
172b860
Compare
My only thoughts on enhancing this client are around how to close the session automatically when the object is detroyed (so it doesn’t leave open sessions dangling). The problem can be pushed up to consumers to explicitly call the close_session. There are some patterns for auto-closing stuff that generally work with class methods, like |
spec/lib/wos_client_spec.rb
Outdated
@@ -0,0 +1,67 @@ | |||
require 'spec_helper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this line because it is done in the .rspec
file.
172b860
to
3da5283
Compare
Fix #186
This explores using the ruby savon gem for SOAP.
Use in
rails c
I use this with a
config/settings.local.yml
file that contains the actual auth-token.TODO:
WosClient.search
functionality (see Web of Science queries #223)Related issues: