Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of WoS Client issues - non actionable, notes only #224

Closed
dazza-codes opened this issue Sep 29, 2017 · 1 comment
Closed

Discussion of WoS Client issues - non actionable, notes only #224

dazza-codes opened this issue Sep 29, 2017 · 1 comment
Labels

Comments

@dazza-codes
Copy link
Contributor

This issue can accumulate commentary about working on the new WoS SOAP API.

@dazza-codes
Copy link
Contributor Author

From #222 - My only thoughts on enhancing the lib/wos_client.rb are around how to close the session automatically when the object is destroyed (so it doesn’t leave open sessions dangling). The problem can be pushed up to consumers to explicitly call the close_session. There are some patterns for auto-closing stuff that generally work with class methods, like File.open can take a block and then do stuff after the yield is done to clean up file handlers.

@atz atz added the wos_api label Oct 2, 2017
@peetucket peetucket changed the title WoS Client issues Discussion of WoS Client issues Oct 2, 2017
@peetucket peetucket changed the title Discussion of WoS Client issues Discussion of WoS Client issues - non actionable, notes only Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants