Add min limit when add/remove booster #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhe8x
requested changes
Jun 30, 2024
contracts/RewardsBooster.sol
Outdated
| @@ -298,6 +299,8 @@ contract RewardsBooster is Initializable, OwnableUpgradeable, IRewardsBooster, S | |||
| deploymentPool.accRewardsPerBooster = accRewardsPerBooster; | |||
| totalBoosterPoint += _amount; | |||
|
|
|||
| require(deploymentPool.boosterPoint >= minimumDeploymentBooster, 'RB015'); | |||
There was a problem hiding this comment.
I thought you should check deploymentPool.accountBooster[_account]
There was a problem hiding this comment.
can you add a test to cover this scenaio? when there is boost bigger than min for a deployment and a user tries to add boost smaller than min, it should fail.
|
@nz-neooo what do you think of |
|
Now it's limited to the total deployment booster. If we want to apply "minimum", limited to the account will be simple and clear. |
ianhe8x
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.