added unpadded base64 builtins #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekroTJA
requested changes
Nov 23, 2023
pkg/goatfile/template_builtins.go
Outdated
| "isset": builtin_isset, | ||
| "json": builtin_json, | ||
| "base64": builtin_base64, | ||
| "base64url": builtin_base64Url, |
There was a problem hiding this comment.
To have clearer consistency across bult-in functions, I would re-name this to base64Url.
pkg/goatfile/template_builtins.go
Outdated
| "base64": builtin_base64, | ||
| "base64url": builtin_base64Url, | ||
| "base64Unpadded": builtin_base64Unpadded, | ||
| "base64urlUnpadded": builtin_base64UrlUnpadded, |
There was a problem hiding this comment.
Same to the change above, I would re-name this to base64UrlUnpadded for better consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched current
base64andbase64urlbehavior to include padding and added additionalbase64Unpaddedandbase64urlUnpaddedbuiltins to still allow unpadded base64 encoding.