Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-raw std encoding in builtin base64 template functions #48

Closed
zekroTJA opened this issue Nov 22, 2023 · 0 comments · Fixed by #52
Closed

Add support for non-raw std encoding in builtin base64 template functions #48

zekroTJA opened this issue Nov 22, 2023 · 0 comments · Fixed by #52
Assignees
Labels
enhancement New feature or request

Comments

@zekroTJA
Copy link
Member

zekroTJA commented Nov 22, 2023

Currently, both builtin template functions base64 and base64url use the base64.RawStdEncodingor base64.RawURLStdEncoding.

Because this might be unexpected behavior, the builtin functions using the raw encoding should be renamed to base64Unpadded and base64urlUnpadded and the two functions base64 and base64Url should use the default encoding.

Because this is a breaking change, this should be implemented before v1.0.

@zekroTJA zekroTJA added the enhancement New feature or request label Nov 22, 2023
@zekroTJA zekroTJA added this to the Release v1.0.0 milestone Nov 22, 2023
@manego manego self-assigned this Nov 23, 2023
@manego manego linked a pull request Nov 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants