-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main.js: Combine presets/registers in addons
field
#9246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/kd123dzt9 |
2 tasks
addons
fieldaddons
field
addons
fieldaddons
field
self-merging @tmeasday @ndelangen |
meirish
added a commit
to hashicorp/structure
that referenced
this pull request
Jan 2, 2020
This was referenced Jan 20, 2020
meirish
added a commit
to hashicorp/structure
that referenced
this pull request
Jan 21, 2020
* add packages and config for storybook * add story blueprint and test * update storybook so we can use addon docs auto-generation * use new more succinct main.js config for storybook - see storybookjs/storybook#9246 * add generated preview-head to gitignore * add top-level storybook:build yarn script * add storybook output dir to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9245
What I did
First implementation of a combined
addons
entry inmain.js
Before: Presets are a “superset” of addons
After: Addons are a “superset” of presets
Also the following works if you want to be more precise / backwards compatible:
Assumptions:
/register
, e.g.@storybook/addon-actions/register
. I've checked and this seems to be the case.addons
function, they can usemanagerEntries
instead.How to test
See updated examples:
official-storybook
,vue-kitchen-sink
,cra-ts-kitchen-sink