Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Storybook setup #2

Merged
merged 7 commits into from
Jan 21, 2020
Merged

Storybook setup #2

merged 7 commits into from
Jan 21, 2020

Conversation

meirish
Copy link
Collaborator

@meirish meirish commented Dec 23, 2019

Adds storybook setup and blueprints that will create stories when generating an st-component.

@meirish meirish force-pushed the f-storybook-setup branch from b8f5e55 to a31dff0 Compare January 2, 2020 14:53
@meirish meirish force-pushed the f-storybook-setup branch from a31dff0 to a4a8735 Compare January 2, 2020 14:59
"nodetest": "mocha node-tests --recursive",
"storybook": "start-storybook -p 6006 -s dist",
"storybook:build": "build-storybook",
"storybook:docs-deploy": "yarn build -prod && build-storybook --docs"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should do a build w/o the canvas tab - I think that's what we want but if not we can change it later

@joshuaogle
Copy link

Looks good 👍 The component and addon commands worked great.

Trying to run storybook before storybook:docs-deploy gave me an error because the dist directory wasn't there yet. Is that expected? Also, just curious, do we intend for people to need to go into the structure-core package to do some of these commands or do we plan on surfacing those at the root level?

@meirish
Copy link
Collaborator Author

meirish commented Jan 14, 2020

Thanks for looking @joshuaogle! Running storybook needs to be done with yarn start in another tab - the server doesn't stop output to the terminal so you can't run it in one command like you can the storybook:docs-deploy does. I think for now, most of the work will be done in the various folders in packages so you'll need to switch folders, but for stuff like the storybook build, you make a good point that it could be moved to the root as well. I'll add that here!

@meirish
Copy link
Collaborator Author

meirish commented Jan 21, 2020

Added that top-level command, so I'm going to go ahead and merge this! Thanks for taking a look.

@meirish meirish merged commit 5f9c021 into master Jan 21, 2020
@meirish meirish deleted the f-storybook-setup branch January 21, 2020 20:18
CITguy added a commit that referenced this pull request Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants