Add more imports eslint rules
#2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
maintenance
Codecov Report
@@ Coverage Diff @@
## master #2589 +/- ##
=========================================
Coverage ? 32.68%
=========================================
Files ? 397
Lines ? 8835
Branches ? 954
=========================================
Hits ? 2888
Misses ? 5268
Partials ? 679
Continue to review full report at Codecov.
|
igor-dv
approved these changes
Dec 28, 2017
| @@ -17,6 +17,7 @@ module.exports = { | |||
| }, | |||
| settings: { | |||
| 'import/core-modules': ['enzyme'], | |||
| 'import/ignore': ['node_modules\\/(?!@storybook)'], | |||
There was a problem hiding this comment.
What is the usecase? I've tried to lint with this setting and without - nothing happened.
Hypnosphi
removed
the
patch:yes
This was referenced Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: we don't get eslint errors for wrong named and default imports, which sometimes leads to bugs (e.g. #2576)
For those rules to work when importing our own packages, I had to add
jsnext:mainfor all the packages that have a compiled file as theirmain