[3.3.3] eslint: Unable to resolve path to module @storybook/react

[DimaRGB]

Issue details

After update to 3.3.3 see eslint error: Unable to resolve path to module @storybook/react. (import/no-unresolved)

Please specify which version of Storybook and optionally any affected addons that you're running

• @storybook/react 3.3.3

Screenshots / Screencast / Code Snippets (Optional)

import * as storybook from '@storybook/react';

eslintrc.js:

  ...
  parserOptions: {
    ecmaVersion: 8,
    sourceType: 'module',
    ecmaFeatures: {
      impliedStrict: true,
      jsx: true,
    },
  },
  ...

[Hypnosphi]

Probably related to adding jsnext:main in #2589

[DimaRGB]

seems like eslint try to use jsnext:main but src folder not published.

[alansouzati]

hey, great that we have a merged PR for this! :) Any news when we will have it released? also, I believe this issue can be closed?

[Hypnosphi]

@shilman how do you feel about a patch release (or maybe even a minor, once we decided to have more of them)?

[Hypnosphi]

Fix released as 3.3.4. Sorry for the delay

[hswolff]

Sadly I'm still seeing this issue.

The PR only removed src from the root .npmignore and not from the individual package itself: https://github.com/storybooks/storybook/blob/master/app/react/.npmignore#L2

I believe we need to remove that from the individual package to have the src directory published as well.

[Hypnosphi]

Oh I see. Would you like to make a PR?

[hswolff]

Incoming!

[hswolff]

PR: #2677

[csi-lk]

Hmm if I manually remove src line from the .npmignore in the @storybook/react folder I still get this eslint error, it could be i'm misunderstanding the solution?

[hswolff]

You mean in your node_modules folder in your application? I'm guessing that it's because the jsnext:main value points to a file that doesn't exist. Perhaps try copying over the src/ folder from this repo into your node_modules folder, which should fix the issue. May be good to do that to verify. That's what my PR will change when a new npm package is published.

[csi-lk]

I ended up giving up and reverting, will just wait for this change to come through, cheers