Ensure examples build in CI #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made sure to run the actions twice, so that the cache is hit. |
This was referenced Jun 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem this addresses is that we need to ensure that
yarn installis run no matter what, even if the cache is restored. This is because yarn relies on having aninstall-state.gzfile that is gitignored and created during installations. We were skipping the installation entirely before if there was a cache, which is the reason that #45 is failing in CI.This also adds a missing dependency,
@sveltejs/vite-plugin-svelteto the svelte example. It would be yarn installed along with the rest of the workspace, but for folks using npm or using the example as a guide, it's important to have it there.