Do not depend on framework plugins (mostly) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
41-remove-some-deps
branch
from
2904bb2 to
cb3d82a
Compare
eirslett
approved these changes
Jun 26, 2021
|
@IanVS Did this PR break the example packages? Do we need to update their package.json to include the correct dependencies? |
|
I'll fix them up. I wonder why CI passed on this PR originally... (Edit: The CI problem was a different issue, which I've fixed in #51.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
This removes the direct dependency on a few plugins, most notably @storybook/addon-svelte-csf, which causes @storybook/svelte to also be installed, which can cause storybook to run in svelte mode when it shouldn't.
This takes the approach of moving vue and svelte addons/plugins to devDependencies and throwing a friendly error message if they are attempted to be required but are not found.
I did not give react the same treatment, because I am planning to publish a forked version of plugin-react-refresh which should allow us to restart the builder when stories change, so that changes at least appear, even if they're not HMR'ed.