Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validation websocket logic to a durable object #293

Closed
Tracked by #220
hugomrdias opened this issue Dec 13, 2022 · 1 comment · Fixed by #449
Closed
Tracked by #220

Move validation websocket logic to a durable object #293

hugomrdias opened this issue Dec 13, 2022 · 1 comment · Fixed by #449
Assignees
@travis
Milestone
w3up phase 3

Comments

@hugomrdias
Copy link
Contributor

hugomrdias commented Dec 13, 2022 •
edited
Loading

The voucher validation and recover validation can take a long time with the current logic because it uses KV, websockets on workers and polls from the KVs until it finds the delegation to send back.

Because KVs are eventually consistent it can take a bit to get the delegation into the KV responding to the websocket, if we move this to the durable object handling AWAKE device sync it will be instant.

Maybe we can even avoid storing delegations.

This would allow better feedback to the user because we have a direct connection to it and we can send errors.
@hugomrdias hugomrdias changed the title Move websocket logic to a durable object Move validation websocket logic to a durable object Dec 13, 2022
@hugomrdias hugomrdias self-assigned this Dec 13, 2022
@hugomrdias hugomrdias added this to the w3up phase 2 milestone Jan 13, 2023
@hugomrdias hugomrdias mentioned this issue Jan 16, 2023
Closed
95 tasks
@hugomrdias hugomrdias removed their assignment Feb 7, 2023
@travis travis self-assigned this Feb 8, 2023
@heyjay44 heyjay44 mentioned this issue Feb 9, 2023
Closed
83 tasks
@heyjay44 heyjay44 modified the milestones: w3up phase 2, w3up phase 3 Feb 9, 2023
@heyjay44 heyjay44 assigned heyjay44 and unassigned heyjay44 Mar 3, 2023
@heyjay44
Copy link
Contributor

heyjay44 commented Mar 3, 2023

PR here: #449

@heyjay44 heyjay44 linked a pull request Mar 3, 2023 that will close this issue
feat: move validation flow to a Durable Object to make it ⏩ fast ⏩ fast ⏩ fast ⏩ #449
Merged
2 tasks
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@olizilla
feat: delegate access to spaces (storacha#293)
441d757 
Allow user to delegate access to a space.

Adds createDelegation to keyring-core and chases it through
{react,solid}-keyring


https://user-images.githubusercontent.com/58871/214885759-2bcf7167-7001-4ffd-b5f4-a0d4b51a9355.mov

To keep this PR reviewable, importing delegations will be added in a
subsequent PR.

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release keyring-core 2.1.0 (storacha#342)
0c661c6 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@keyring-core-v2.0.1...keyring-core-v2.1.0)
(2023-02-02)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release keyring-core 2.1.1 (storacha#376)
33391f9 
🤖 I have created a release *beep* *boop*
---


##
[2.1.1](storacha/w3ui@keyring-core-v2.1.0...keyring-core-v2.1.1)
(2023-02-03)


### Features

* add `sameAs` function to compare spaces by DID ([storacha#268](storacha/w3ui#268)) ([3dcd647](storacha/w3ui@3dcd647))
* fix bug in `name` function ([storacha#268](storacha/w3ui#268)) ([3dcd647](storacha/w3ui@3dcd647))
* add createDelegation function to delegate access to spaces ([storacha#293](storacha/w3ui#293)) ([441d757](storacha/w3ui@441d757))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release react-keyring 2.1.0 (storacha#372)
9cace63 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@react-keyring-v2.0.1...react-keyring-v2.1.0)
(2023-02-03)


### Features

* "Headless" UI components
([#136](storacha/w3ui#136))
([46583e0](storacha/w3ui@46583e0))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))
* support `as` prop in uploader component
([storacha#236](storacha/w3ui#236))
([c802e99](storacha/w3ui@c802e99)),
closes [storacha#235](storacha/w3ui#235)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release react-keyring 3.0.0 (storacha#377)
c07b7a8 
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](storacha/w3ui@react-keyring-v2.1.0...react-keyring-v3.0.0)
(2023-02-06)


### ⚠ BREAKING CHANGES

* no breaking changes, but a major version bump because I made an error operating release-please

### Features

* "Headless" UI components
([#136](storacha/w3ui#136))
([46583e0](storacha/w3ui@46583e0))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([a69a95b](storacha/w3ui@a69a95b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release solid-keyring 2.1.0 (storacha#374)
cd09333 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@solid-keyring-v2.0.1...solid-keyring-v2.1.0)
(2023-02-06)


### Features

* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([a69a95b](storacha/w3ui@a69a95b))


### Bug Fixes

* get solid examples working again
([storacha#199](storacha/w3ui#199))
([78ad7e9](storacha/w3ui@78ad7e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions
chore(main): release w3console 1.0.0 (storacha#416)
5650893 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-03-23)


### ⚠ BREAKING CHANGES

* use new account model
([storacha#400](storacha/w3ui#400))

### Features

* add terms of service page
([storacha#417](storacha/w3ui#417))
([6deb24d](storacha/w3ui@6deb24d))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([814a293](storacha/w3ui@814a293))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([2266eb2](storacha/w3ui@2266eb2))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([441d757](storacha/w3ui@441d757))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([a69a95b](storacha/w3ui@a69a95b))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([ba9a3bf](storacha/w3ui@ba9a3bf))
* publish console to IPFS & Cloudflare from CI
([storacha#287](storacha/w3ui#287))
([e2a833e](storacha/w3ui@e2a833e))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([e0de2cc](storacha/w3ui@e0de2cc))
* use new account model
([storacha#400](storacha/w3ui#400))
([66dd20b](storacha/w3ui@66dd20b))
* w3console example app
([storacha#255](storacha/w3ui#255))
([df08029](storacha/w3ui@df08029))


### Bug Fixes

* add _headers ([storacha#418](storacha/w3ui#418))
([4eb1da1](storacha/w3ui@4eb1da1))
* fix w3console styling
([storacha#320](storacha/w3ui#320))
([74a298c](storacha/w3ui@74a298c))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([3668f3b](storacha/w3ui@3668f3b))
* w3console polish
([storacha#284](storacha/w3ui#284))
([9a67365](storacha/w3ui@9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@olizilla
feat: delegate access to spaces (storacha#293)
d99c96c 
Allow user to delegate access to a space.

Adds createDelegation to keyring-core and chases it through
{react,solid}-keyring


https://user-images.githubusercontent.com/58871/214885759-2bcf7167-7001-4ffd-b5f4-a0d4b51a9355.mov

To keep this PR reviewable, importing delegations will be added in a
subsequent PR.

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release keyring-core 2.1.0 (storacha#342)
6871e08 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@keyring-core-v2.0.1...keyring-core-v2.1.0)
(2023-02-02)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release keyring-core 2.1.1 (storacha#376)
e74409c 
🤖 I have created a release *beep* *boop*
---


##
[2.1.1](storacha/w3ui@keyring-core-v2.1.0...keyring-core-v2.1.1)
(2023-02-03)


### Features

* add `sameAs` function to compare spaces by DID ([storacha#268](storacha/w3ui#268)) ([5894cdc](storacha/w3ui@5894cdc))
* fix bug in `name` function ([storacha#268](storacha/w3ui#268)) ([5894cdc](storacha/w3ui@5894cdc))
* add createDelegation function to delegate access to spaces ([storacha#293](storacha/w3ui#293)) ([d99c96c](storacha/w3ui@d99c96c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release react-keyring 2.1.0 (storacha#372)
ae69d6a 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@react-keyring-v2.0.1...react-keyring-v2.1.0)
(2023-02-03)


### Features

* "Headless" UI components
([#136](storacha/w3ui#136))
([b702889](storacha/w3ui@b702889))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))
* support `as` prop in uploader component
([storacha#236](storacha/w3ui#236))
([54c14ea](storacha/w3ui@54c14ea)),
closes [storacha#235](storacha/w3ui#235)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release react-keyring 3.0.0 (storacha#377)
1b692e0 
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](storacha/w3ui@react-keyring-v2.1.0...react-keyring-v3.0.0)
(2023-02-06)


### ⚠ BREAKING CHANGES

* no breaking changes, but a major version bump because I made an error operating release-please

### Features

* "Headless" UI components
([#136](storacha/w3ui#136))
([b702889](storacha/w3ui@b702889))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([f9df8a8](storacha/w3ui@f9df8a8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release solid-keyring 2.1.0 (storacha#374)
c7bd96e 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](storacha/w3ui@solid-keyring-v2.0.1...solid-keyring-v2.1.0)
(2023-02-06)


### Features

* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([f9df8a8](storacha/w3ui@f9df8a8))


### Bug Fixes

* get solid examples working again
([storacha#199](storacha/w3ui#199))
([9b8c1ef](storacha/w3ui@9b8c1ef))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions
chore(main): release w3console 1.0.0 (storacha#416)
dfdceac 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-03-23)


### ⚠ BREAKING CHANGES

* use new account model
([storacha#400](storacha/w3ui#400))

### Features

* add terms of service page
([storacha#417](storacha/w3ui#417))
([e216efd](storacha/w3ui@e216efd))
* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([22d917a](storacha/w3ui@22d917a))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([92fa065](storacha/w3ui@92fa065))
* delegate access to spaces
([storacha#293](storacha/w3ui#293))
([d99c96c](storacha/w3ui@d99c96c))
* import a space into w3console
([storacha#309](storacha/w3ui#309))
([f9df8a8](storacha/w3ui@f9df8a8))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([4f5cf4f](storacha/w3ui@4f5cf4f))
* publish console to IPFS & Cloudflare from CI
([storacha#287](storacha/w3ui#287))
([df4715a](storacha/w3ui@df4715a))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([c031ff7](storacha/w3ui@c031ff7))
* use new account model
([storacha#400](storacha/w3ui#400))
([b594536](storacha/w3ui@b594536))
* w3console example app
([storacha#255](storacha/w3ui#255))
([fbcdc42](storacha/w3ui@fbcdc42))


### Bug Fixes

* add _headers ([storacha#418](storacha/w3ui#418))
([625199d](storacha/w3ui@625199d))
* fix w3console styling
([storacha#320](storacha/w3ui#320))
([31cbe91](storacha/w3ui@31cbe91))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([e115f9f](storacha/w3ui@e115f9f))
* w3console polish
([storacha#284](storacha/w3ui#284))
([654d507](storacha/w3ui@654d507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis travis

Labels
None yet
Projects
None yet
Milestone
w3up phase 3
3 participants
@travis @hugomrdias @heyjay44