refactor: add cause as a param to deregister #136
Merged
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
pushed a commit
that referenced
this pull request
Feb 5, 2025
Reverts storacha/console#134 (which reverted storacha/console#132) Last night, this was still failing locally. This morning it's working again. I've done nothing but investigate. I now think the Blob protocol was a red herring. I think something else caused us to send a receipt that the client chokes on, and that that'll happen regardless of this change. If it comes back, we should investigate further, but I don't think this is what did it.
fforbeck
pushed a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.14.0](storacha/console@w3console-v1.13.1...w3console-v1.14.0) (2024-10-21) ### Features * Actually put error in console, as promised ([#131](storacha/console#131)) ([c194463](storacha/console@c194463)) ### Bug Fixes * Revert "fix: Revert "feat: Use Blob protocol"" (😩) ([#136](storacha/console#136)) ([c75f3db](storacha/console@c75f3db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new blob/remove flow introduced in storacha/w3infra#458 removes the ucan-stream (storacha/project-tracking#304) and updates the space-diff table directly from the blob-registry.
To properly create a space-diff entry in deregister, the invocation CID is required. However, unlike register, it is not currently passed as a parameter. This update ensures the necessary data is available for consistent and accurate tracking of space usage.