🐛 fix bug in crt0.S interrupt setup #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the processor startup code
sw/common/crt0.S
.Bug Description
Imagine the following scenario:
mip
CSR.crt0
code of the new program problem will (re-)init the stackpointer and will also override the entry point for all exceptions (mtvec
) as well as disabling all interrupts.mtvec
) and all the interrupt configuration have not. Hence, the bootloader's trap handler gets called but with a modified stack that has already been setup for the new program.Bug Fix
The very first thing
crt0.S
has to do is to clear the global interrupts enable flag (mstatus.mie
).