Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-rc (hackney ~> 1.9.0) #24

Merged
merged 16 commits into from
Mar 3, 2018
Merged

1.0.0-rc (hackney ~> 1.9.0) #24

merged 16 commits into from
Mar 3, 2018

Conversation

stephenmoloney
Copy link
Owner

@stephenmoloney stephenmoloney commented Feb 25, 2018

Description:

Work on 1.0.0-rc1

See changelog for description of more changes.

Pending Enhancements

  • Add retries to more of the error clauses... not just after @stream_timeout - eg specifically on error, unexpected streaming error while streaming or after {:hackney_response, _stream_ref, data}
  • Handle after {:hackney_response, _stream_ref, data} more elegantly
  • More elegant error handling - work already done in another branch, just needs to be transposed.

Issues Encountered:

  • Cannot successfully use latest hackney versions 1.10.1, 1.10.0 or 1.11.0 primarily due to issue 447 for both reasons laid out in that issue. Made an attempt to debug it in :hackney itself but didn't succeed. I will make a branch showing a reproducible failing build.
  • ssl_closed error apparrantly with all versions but builds still pass.

@stephenmoloney stephenmoloney changed the title WIP:Hackney 1.9.0 rc new WIP:1.0.0-rc (hackney ~> 1.9.0) Feb 25, 2018
@stephenmoloney stephenmoloney self-assigned this Feb 26, 2018
@stephenmoloney stephenmoloney merged commit 803d660 into master Mar 3, 2018
@stephenmoloney stephenmoloney changed the title WIP:1.0.0-rc (hackney ~> 1.9.0) 1.0.0-rc (hackney ~> 1.9.0) Mar 3, 2018
@stephenmoloney stephenmoloney deleted the hackney_1.9.0_rc_new branch October 3, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant