-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0-rc (hackney ~> 1.9.0) #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no match of right hand side value: {:error, :normal}
f0177dc
to
ed525cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Work on
1.0.0-rc1
Fastimage.info
function with both size and type in one pass #18 (done)See changelog for description of more changes.
Pending Enhancements
after @stream_timeout
- eg specifically onerror, unexpected streaming error while streaming
or after{:hackney_response, _stream_ref, data}
{:hackney_response, _stream_ref, data}
more elegantlyIssues Encountered:
1.10.1
,1.10.0
or1.11.0
primarily due to issue 447 for both reasons laid out in that issue. Made an attempt to debug it in:hackney
itself but didn't succeed. I will make a branch showing a reproducible failing build.