Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0rc checklist #12

Closed
10 tasks done
stephenmoloney opened this issue Dec 16, 2017 · 1 comment
Closed
10 tasks done

1.0rc checklist #12

stephenmoloney opened this issue Dec 16, 2017 · 1 comment

Comments

@stephenmoloney
Copy link
Owner

stephenmoloney commented Dec 16, 2017 •
edited
Loading

  • returned errors, some degree of tidy up needed here for errors bubbling up from private functions
  • make multiple versions of :hackney acceptable
  • support binaries in addition to a file path or uri
  • change return image type return types to atoms @type image_types :: :bmp | :gif | :jpg | :png
  • change errors to Elixir Exceptions - eg UnknownTypeError
  • introduce type -> {:ok, type} and size -> {:ok, size}, type!, and size! function formats [will need to change raise(inspect(error)) -> raise(error) ]
  • credo linting
  • ensure close_stream in all relevant locations
  • added new Fastimage.info function
  • add options to type/1, size/1 and info/1 to allow manual overrides on
    the otherwised fixed values for stream_timeout, max_redirect_retries and
    max_error_retries
@stephenmoloney stephenmoloney mentioned this issue Feb 25, 2018
Merged
@stephenmoloney
Copy link
Owner Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephenmoloney