-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#23 - Add source comments from file descriptor #31
Conversation
…nterfaces, and services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great!
Made a few stylistic asks/questions, but overall is great.
Can you add some comments to the simple.proto
-type files that are used for ts-proto's test suite, and then in theory we should be able to see some example-generated comments in the PR (b/c the code generated for the proto/integration tests is purposefully checked in to see these sort of changes in the diffs). I could also try that if the test suite setup is too jank (it's not just npm test
), but their is an overview in the readme that hopefully works. Let me know if it doesn't / you don't have time, and I'll throw in a few example comments to see what the output looks like before merging.
…ents. Added use of trailing comments. Added file header comment from the syntax declaration.
@stephenh Otherwise, I think I covered all the asks above. Let me know if you need any additional changes. |
Looks great, thanks! I do actually check in the generated source files; I know in downstream / real projects that is an anti-pattern but given ts-proto's job is producing that output, I basically treat it as an mini-integration test to see how the output has changed in the PRs/diffs/etc. I'll go ahead and do a follow up commit with those changes now. |
Added comments from fileDescriptor.sourceCodeInfo to enums, message interfaces, and services.
Should resolve issue 23
#23