-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options to disable generation of serializers, to/from json, and… #28
Conversation
n3rdyme
commented
Feb 15, 2020
- Added options to disable generation of serializers, to/from json, and services.
- Added header to disable es-lint and ts-check
… services. Added header to disable lint
@stephenh |
I'll locally merged this PR and pushed it to master (there was a minor conflict from your other PR). I also made the If you have more examples of ts-nocheck-requiring behavior, I'm happy to try and fix those too. I'm slightly (slightly :-)) open to a |
Can you check how master works for you with your two PRs merged and then I'll make a release? Thanks again! |
@stephenh I tested from latest master:
Everything is working for me. Thanks for the merge! BTW... if anyone does need @ts-nocheck, they can do this at the top of the offending proto files:
Which then outputs in the source as needed:
So, I guess that works ;) |
Lol, that's hilarious. :-) Great that it works for you. I'd gone ahead and released master (for a few non-doc commits before that) as v1.11.0. |