-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relative path in docs incorrect on when build on windows #1708
Comments
After changing my setup to run the build inside a Docker container during development I can confirm that the separator is correct when built on a Linux system. This points to earlier assumption that this is an OS related problem. Funnily enough the problem is usually reversed (as in generated paths are not using
|
i had the problem aswell, my collegues are on mac and linux. iam the dude with windows. i found the code: cheers |
PR! |
fixes stenciljs#1708 I was just trying to make some Ionic docs changes and ended up down a rabbit hole. I'm submitting this one line fix in case that's all that needs to be done, but I have only tested it on my own Windows 10 computer and it resolved the issue.
Think this can be closed by 22d9c93 |
Stencil version:
I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
Links to other components use system path separator instead of URL path separator.
Take this readme as an example. Because it was built on windows it uses
\
as a path separator instead of the correct/
.Expected behavior:
Paths in
.md
files can safely be assumed to be intended to be consumed on the internet, so the path separator should always be/
.Steps to reproduce:
Build a multi-component stencil project on a windows system and check the generated
readme.md
files.Related code:
// insert any relevant code here
Other information:
The text was updated successfully, but these errors were encountered: