Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(text-wrap): replace directive with class #19144

Merged
merged 6 commits into from
Aug 26, 2019

Conversation

rtpHarry
Copy link
Contributor

I'm not sure if this is correct but I have created the PR ready for merge if this is an issue. Please review before accepting.

I thought that the new approved way for Ionic 4 was to use ion-text-wrap over the text-wrap directive.

As I understand it this is a general policy as not all platforms support directives.

It seems the text-wrap directive was still lurking in the usage examples.

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Aug 21, 2019
@brandyscarney
Copy link
Member

Yes, this is correct! Thank you! Could you please run npm run build and commit the changes? It should make some automatic updates to the readme file. 🙂

@rtpHarry
Copy link
Contributor Author

rtpHarry commented Aug 24, 2019

I'm on Window 10. It's converted all the include paths in the docs from / to \:

image

Is this going to mess everything up if I try to commit it?

I did npm i then npm i in the core folder then npm run build.

@rtpHarry
Copy link
Contributor Author

Done some digging and it seems that its currently an issue with Stencil on Windows:

stenciljs/core#1708

@rtpHarry rtpHarry changed the title docs(item): wrap usage used directive instead of class docs(text-wrap): replace directive with class Aug 24, 2019
@rtpHarry
Copy link
Contributor Author

Made a patch for my install, and also found some more references once I had it as a local repo.

I think this is good to go now?

@brandyscarney
Copy link
Member

Thank you!

@manucorporat see #19144 (comment)

@brandyscarney brandyscarney merged commit d4db3af into ionic-team:master Aug 26, 2019
@rtpHarry rtpHarry deleted the patch-6 branch August 27, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants