-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(text-wrap): replace directive with class #19144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, this is correct! Thank you! Could you please run |
Done some digging and it seems that its currently an issue with Stencil on Windows: |
Made a patch for my install, and also found some more references once I had it as a local repo. I think this is good to go now? |
Thank you! |
liamdebeasi
pushed a commit
that referenced
this pull request
Aug 27, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is correct but I have created the PR ready for merge if this is an issue. Please review before accepting.
I thought that the new approved way for Ionic 4 was to use
ion-text-wrap
over thetext-wrap
directive.As I understand it this is a general policy as not all platforms support directives.
It seems the
text-wrap
directive was still lurking in the usage examples.