avoid Taskpool.spawn within {.async.} for Nim 2.0
#5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Nim 2.0, attempting to use `Taskpool.spawn` inside `{.async.}` `proc`
leads to `Error: cannot generate destructor for generic type: Isolated`.
Add an intermediate wrapper `proc` that performs the `spawn` operation
to workaround the problem.
|
@mratsim in Nim 2.0 there is weird interaction between make -j update && make -j deps NIM_COMMIT=version-2-0 && make -j nimbus_beacon_node NIM_COMMIT=version-2-0 |
|
While the extra wrapper is ugly, it unblocks Nim 2.0 CI in #5142 |
|
An upstream bug should be filed. I'd assume it can be reproduced with just std/tasks and std/asyncdispatch or plain closure iterators. |
nim-lang/Nim#22305 looks likely. If it's not that, when that's fixed, this can be investigated more and a new bug filed. |
tersec
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nim 2.0, attempting to use
Taskpool.spawninside{.async.}procleads toError: cannot generate destructor for generic type: Isolated.Add an intermediate wrapper
procthat performs thespawnoperation to workaround the problem.