update tested Nim versions #5142

etan-status · 2023-06-28T22:05:15Z

Add version-2-0 testing, and make upstream version testing Linux only.

.github/workflows/ci.yml

tersec · 2023-06-29T06:41:18Z

For 2.0, it's currently failing with

2023-06-29T05:40:51.2060942Z stack trace: (most recent call last)
2023-06-29T05:40:51.2061671Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/lib/std/tasks.nim(117, 12) toTask
2023-06-29T05:40:51.2062649Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-blscurve/blscurve/bls_batch_verifier.nim(219, 22) template/generic instantiation of `spawn` from here
2023-06-29T05:40:51.2063578Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-taskpools/taskpools/taskpools.nim(515, 26) template/generic instantiation of `toTask` from here
2023-06-29T05:40:51.2064294Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-taskpools/taskpools/taskpools.nim(514, 16) Error: 'toTask' takes a GC safe call expression
2023-06-29T05:40:51.2098697Z make: *** [Makefile:423: deposit_contract] Error 1

I definitely find it worth testing version-2-0 one platform, though, especially as it's already RC2, so while Nimbus is a ways from switching to it, it should be becoming a stable target at least.

tersec · 2023-06-29T08:20:38Z

Depends on #5143

github-actions · 2023-06-29T08:56:06Z

Unit Test Results

        9 files ±0   1 089 suites ±0 42m 1s ⏱️ + 2m 5s
  3 845 tests ±0   3 566 ✔️ ±0 279 💤 ±0 0 ❌ ±0
15 886 runs ±0 15 581 ✔️ ±0 305 💤 ±0 0 ❌ ±0

Results for commit eda9550. ± Comparison against base commit 8ffb80e.

♻️ This comment has been updated with latest results.

tersec · 2023-06-29T11:42:17Z

2023-06-29T11:27:18.5385728Z �[92mBuilding:�[39m build/deposit_contract
2023-06-29T11:27:18.5401648Z �[92mBuilding:�[39m build/resttest
2023-06-29T11:27:18.5465428Z [using Nim version upstream/version-2-0]
2023-06-29T11:27:18.5480574Z [using Nim version upstream/version-2-0]
2023-06-29T11:27:19.2793445Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/config/nim.cfg' [Conf]
2023-06-29T11:27:19.2799965Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/config/config.nims' [Conf]
2023-06-29T11:27:19.2802221Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/config.nims' [Conf]
2023-06-29T11:27:19.2804334Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/ncli/nim.cfg' [Conf]
2023-06-29T11:27:19.2806534Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/ncli/resttest.nim.cfg' [Conf]
2023-06-29T11:27:19.3209798Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/config/nim.cfg' [Conf]
2023-06-29T11:27:19.3211122Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nimbus-build-system/vendor/Nim/config/config.nims' [Conf]
2023-06-29T11:27:19.3212674Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/config.nims' [Conf]
2023-06-29T11:27:19.3213715Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nim.cfg' [Conf]
2023-06-29T11:27:19.3214826Z Hint: used config file '/home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/el/deposit_contract.nim.cfg' [Conf]
2023-06-29T11:27:21.9244430Z Hint: mm: refc; threads: on; opt: none (DEBUG BUILD, `-d:release` generates faster code)
2023-06-29T11:27:21.9246651Z 135043 lines; 2.643s; 260.48MiB peakmem; proj: /home/runner/work/nimbus-eth2/nimbus-eth2/ncli/resttest.nim; out: /home/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/resttest/resttest.json [SuccessX]
2023-06-29T11:27:23.6022955Z SIGSEGV: Illegal storage access. (Attempt to read from nil?)
2023-06-29T11:27:23.8032199Z scripts/compile_nim_program.sh: line 48:  9698 Segmentation fault      (core dumped) "$NIMC" c -f --compileOnly -o:build/${BINARY} "$@" -d:nimCachePathOverride=nimcache/release/${BINARY} "${SOURCE}"
2023-06-29T11:27:23.8041676Z make: *** [Makefile:423: deposit_contract] Error 139
2023-06-29T11:27:23.8046895Z make: *** Waiting for unfinished jobs....
2023-06-29T11:27:47.6327396Z �[92mBuild completed successfully:�[39m build/resttest
2023-06-29T11:27:47.6343047Z ##[error]Process completed with exit code 2.

tersec · 2023-06-29T13:32:22Z

Depends on nim-lang/Nim#22187

Menduist · 2023-06-29T14:11:50Z

FYI, libp2p doesn't work on 2.0 because of nim-lang/Nim#22188 (at least in our CI)

etan-status · 2023-07-10T11:26:37Z

upstream/version-2-0 still fails:

SIGSEGV: Illegal storage access. (Attempt to read from nil?)
scripts/compile_nim_program.sh: line 48:  9761 Segmentation fault      (core dumped) "$NIMC" c -f --compileOnly -o:build/${BINARY} "$@" -d:nimCachePathOverride=nimcache/release/${BINARY} "${SOURCE}"
make: *** [Makefile:423: deposit_contract] Error 139

@narimiran Could it be that backports from devel to version-2-0 are still pending, or are there other issues @tersec?

narimiran · 2023-07-10T15:38:18Z

@narimiran Could it be that backports from devel to version-2-0 are still pending, or are there other issues @tersec?

version-2-0 is currently ~60 commits behind devel, but it's green on the Nim's CIs.

If needed, I can merge those commits from devel to v-2-0.

etan-status · 2023-07-10T15:51:26Z

Would be awesome to have a green version-2-0 CI here :)

narimiran · 2023-07-10T17:31:47Z

Would be awesome to have a green version-2-0 CI here :)

Ok, version-2-0 is now same as devel. Let's see if it helps things here :)

tersec · 2023-07-10T18:11:21Z

upstream/version-2-0 still fails:
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
scripts/compile_nim_program.sh: line 48:  9761 Segmentation fault      (core dumped) "$NIMC" c -f --compileOnly -o:build/${BINARY} "$@" -d:nimCachePathOverride=nimcache/release/${BINARY} "${SOURCE}"
make: *** [Makefile:423: deposit_contract] Error 139
@narimiran Could it be that backports from devel to version-2-0 are still pending, or are there other issues @tersec?

That's probably nim-lang/Nim#22187 -- will trigger rebuild to find out

tersec · 2023-07-10T20:16:16Z

2023-07-10T19:51:17.8581919Z 135221 lines; 2.759s; 260.824MiB peakmem; proj: /home/runner/work/nimbus-eth2/nimbus-eth2/ncli/resttest.nim; out: /home/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/resttest/resttest.json [SuccessX]
2023-07-10T19:51:20.0312987Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/deneb.nim(28, 23) Error: cannot open file: ../../vendor/nim-kzg4844/kzg4844
2023-07-10T19:51:20.0391423Z make: *** [Makefile:423: deposit_contract] Error 1

#5179

Add `version-2-0` testing, and make upstream version testing Linux only.

etan-status · 2023-08-18T17:32:18Z

And, also, as a followup:

add {.raises.} annotation to writeValue nim-json-serialization#64

etan-status · 2023-08-19T07:59:46Z

bump nim-chronicles / nim-json-serialization #5319

tersec · 2023-08-20T03:56:39Z

2023-08-20T03:43:16.7716765Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_light_client.nim(25, 1) template/generic instantiation of `programMain` from here
2023-08-20T03:43:16.7717546Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-testutils/testutils/moduletests.nim(17, 23) template/generic instantiation from here
2023-08-20T03:43:16.7718354Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(1176, 13) Error: loadImpl(LightClientConf, commandLineParams(), version`gensym50,
2023-08-20T03:43:16.7718927Z          "Nimbus light client v23.7.0-659001-stateofus", true, true,
2023-08-20T03:43:16.7719295Z          secondarySourcesRef`gensym51, proc (config`gensym50: LightClientConf;
2023-08-20T03:43:16.7719665Z     sources`gensym50: ref SecondarySources_989856223) {.
2023-08-20T03:43:16.7720025Z     raises: [ConfigurationError].} = if isSome(config`gensym50.configFile):
2023-08-20T03:43:16.7720415Z   addConfigFile(sources`gensym50, Toml, get(config`gensym50.configFile))
2023-08-20T03:43:16.7720791Z , getAppFilename()) can raise an unlisted exception: Exception
2023-08-20T03:43:16.7867739Z make: *** [Makefile:443: nimbus_light_client] Error 1

etan-status · 2023-08-20T06:59:31Z

bump nim-confutils to d784b823be28532aadd77af5c983b6ba18cf33d8 #5329

etan-status · 2023-08-20T10:39:17Z

2023-08-20T10:37:51.3802556Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_beacon_node.nim(2100, 1) template/generic instantiation of `programMain` from here
2023-08-20T10:37:51.3803546Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_beacon_node.nim(2101, 35) template/generic instantiation of `makeBannerAndConfig` from here
2023-08-20T10:37:51.3804438Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_binary_common.nim(200, 13) template/generic instantiation of `load` from here
2023-08-20T10:37:51.3805172Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_binary_common.nim(207, 18) template/generic instantiation of `addConfigFile` from here
2023-08-20T10:37:51.3805906Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(860, 39) template/generic instantiation of `loadFile` from here
2023-08-20T10:37:51.3810508Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-toml-serialization/toml_serialization.nim(156, 13) template/generic instantiation of `readValue` from here
2023-08-20T10:37:51.3811184Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization.nim(30, 9) template/generic instantiation of `readValue` from here
2023-08-20T10:37:51.3811876Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-toml-serialization/toml_serialization/reader.nim(499, 8) template/generic instantiation of `decodeInlineTable` from here
2023-08-20T10:37:51.3812609Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-toml-serialization/toml_serialization/reader.nim(377, 19) template/generic instantiation of `fieldReadersTable` from here
2023-08-20T10:37:51.3813338Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization/object_serialization.nim(256, 34) template/generic instantiation of `makeFieldReadersTable` from here
2023-08-20T10:37:51.3814446Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization/object_serialization.nim(218, 26) template/generic instantiation of `enumAllSerializedFields` from here
2023-08-20T10:37:51.3815310Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization/object_serialization.nim(152, 32) template/generic instantiation of `enumAllSerializedFieldsImpl` from here
2023-08-20T10:37:51.3816087Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization/object_serialization.nim(235, 52) template/generic instantiation of `readFieldIMPL` from here
2023-08-20T10:37:51.3817001Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization/object_serialization.nim(203, 13) template/generic instantiation of `readValue` from here
2023-08-20T10:37:51.3817659Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization.nim(30, 9) template/generic instantiation of `readValue` from here
2023-08-20T10:37:51.3818331Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-toml-serialization/toml_serialization/reader.nim(445, 19) template/generic instantiation of `readValue` from here
2023-08-20T10:37:51.3819044Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-serialization/serialization.nim(29, 19) Warning: The 'ValidIpAddress' type doesn't have a valid default value [UnsafeDefault]
2023-08-20T10:37:52.4238154Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_beacon_node.nim(2100, 1) template/generic instantiation of `programMain` from here
2023-08-20T10:37:52.4239093Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_beacon_node.nim(2101, 35) template/generic instantiation of `makeBannerAndConfig` from here
2023-08-20T10:37:52.4239851Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_binary_common.nim(200, 13) template/generic instantiation of `load` from here
2023-08-20T10:37:52.4240621Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(1181, 13) template/generic instantiation of `loadImpl` from here
2023-08-20T10:37:52.4241261Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(912, 50) template/generic instantiation of `configurationRtti` from here
2023-08-20T10:37:52.4241895Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(709, 19) template/generic instantiation of `setField` from here
2023-08-20T10:37:52.4242562Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(686, 16) template/generic instantiation of `makeDefaultValue` from here
2023-08-20T10:37:52.4243243Z /home/runner/work/nimbus-eth2/nimbus-eth2/vendor/nim-confutils/confutils.nim(632, 3) Error: 'result' requires explicit initialization
2023-08-20T10:37:52.5468315Z make: *** [Makefile:443: nimbus_beacon_node] Error 1

etan-status · 2023-08-20T10:40:45Z

explicitly initialize result nim-confutils#89

etan-status · 2023-08-20T10:43:01Z

bump nim-confutils to 674c9e4c8e0cad2b7193cc9a59c12d39a397750f #5330

tersec · 2023-08-20T12:32:19Z

2023-08-20T12:08:59.3175237Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/gossip_processing/batch_validation.nim(231, 1) Error: cannot generate destructor for generic type: Isolated
2023-08-20T12:08:59.4753808Z make: *** [Makefile:443: nimbus_beacon_node] Error 1

probably related to nim-lang/Nim#22305 as #5142 (comment) notes

etan-status · 2023-09-05T14:00:04Z

avoid Taskpool.spawn within {.async.} for Nim 2.0 #5393

etan-status · 2023-09-05T20:37:57Z

workaround for Nim 2.0 issue with the template nim-ssz-serialization#68

etan-status · 2023-09-05T21:33:35Z

wrap applyExecutionPayload in factories for Nim 2.0 #5395

etan-status · 2023-09-05T21:37:22Z

rename U to maxLen in statediff for Nim 2.0 #5396

etan-status · 2023-09-05T21:40:02Z

fix relative import paths for Nim 2.0 #5397

etan-status · 2023-09-06T12:13:08Z

further reduce stack size of LC helpers for Nim 2.0 #5401

etan-status force-pushed the dev/etan/ci-nim2devel branch 7 times, most recently from 1a5354c to fe089b0 Compare June 28, 2023 22:50

etan-status marked this pull request as ready for review June 28, 2023 23:10

etan-status requested a review from tersec June 28, 2023 23:11

tersec reviewed Jun 28, 2023

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

tersec approved these changes Jun 29, 2023

View reviewed changes

tersec force-pushed the dev/etan/ci-nim2devel branch from 4b350c4 to 4716e7d Compare June 29, 2023 11:18

etan-status added 6 commits July 11, 2023 03:57

update tested Nim versions

f9bb390

Add `version-2-0` testing, and make upstream version testing Linux only.

drop nim prefix for shorter job name

f432468

try improve GitHub sidebar usability

1cf40e0

does replace work?

5a97131

try with additional variable

a91f5b5

add --mm:refc to version-2-0 build

96b546e

etan-status mentioned this pull request Aug 19, 2023

cleanup {.raises.} for writeValue #5308

Merged

Merge branch 'unstable' into dev/etan/ci-nim2devel

0dda9cb

Merge branch 'unstable' into dev/etan/ci-nim2devel

2884c81

Merge branch 'unstable' into dev/etan/ci-nim2devel

619e255

etan-status added 4 commits August 21, 2023 11:18

Merge branch 'unstable' into dev/etan/ci-nim2devel

2b0f2b7

Merge branch 'unstable' into dev/etan/ci-nim2devel

5751864

Merge branch 'unstable' into dev/etan/ci-nim2devel

be4f5c8

Merge branch 'unstable' into dev/etan/ci-nim2devel

9382cca

etan-status mentioned this pull request Sep 5, 2023

avoid Taskpool.spawn within {.async.} for Nim 2.0 #5393

Merged

Merge branch 'unstable' into dev/etan/ci-nim2devel

eda9550

Merge branch 'unstable' into dev/etan/ci-nim2devel

6e00eef

Merge branch 'unstable' into dev/etan/ci-nim2devel

9cbf997

etan-status enabled auto-merge (squash) September 6, 2023 16:42

etan-status merged commit b8db44d into unstable Sep 6, 2023

etan-status deleted the dev/etan/ci-nim2devel branch September 6, 2023 19:00

tersec mentioned this pull request Sep 10, 2023

Restore Windows CI #5411

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update tested Nim versions #5142

update tested Nim versions #5142

etan-status commented Jun 28, 2023

tersec commented Jun 29, 2023 •

edited

Loading

tersec commented Jun 29, 2023

github-actions bot commented Jun 29, 2023 •

edited

Loading

tersec commented Jun 29, 2023

tersec commented Jun 29, 2023 •

edited

Loading

Menduist commented Jun 29, 2023

etan-status commented Jul 10, 2023

narimiran commented Jul 10, 2023

etan-status commented Jul 10, 2023

narimiran commented Jul 10, 2023

tersec commented Jul 10, 2023

tersec commented Jul 10, 2023

etan-status commented Aug 18, 2023

etan-status commented Aug 19, 2023

tersec commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

tersec commented Aug 20, 2023 •

edited

Loading

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 6, 2023

update tested Nim versions #5142

update tested Nim versions #5142

Conversation

etan-status commented Jun 28, 2023

tersec commented Jun 29, 2023 • edited Loading

tersec commented Jun 29, 2023

github-actions bot commented Jun 29, 2023 • edited Loading

Unit Test Results

tersec commented Jun 29, 2023

tersec commented Jun 29, 2023 • edited Loading

Menduist commented Jun 29, 2023

etan-status commented Jul 10, 2023

narimiran commented Jul 10, 2023

etan-status commented Jul 10, 2023

narimiran commented Jul 10, 2023

tersec commented Jul 10, 2023

tersec commented Jul 10, 2023

etan-status commented Aug 18, 2023

etan-status commented Aug 19, 2023

tersec commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

etan-status commented Aug 20, 2023

tersec commented Aug 20, 2023 • edited Loading

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 5, 2023

etan-status commented Sep 6, 2023

tersec commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

tersec commented Jun 29, 2023 •

edited

Loading

tersec commented Aug 20, 2023 •

edited

Loading