Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "data gas" to "blob gas" #5216

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

henridf
Copy link
Contributor

@henridf henridf commented Jul 27, 2023

Per ethereum/consensus-specs#3461

Once status-im/nim-web3#91 lands, I will update the pointer here and un-draft the PR.

@henridf henridf changed the base branch from stable to unstable July 27, 2023 22:36
@henridf henridf changed the title Rename data gas blob gas Rename "data gas" to "blob gas" Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Unit Test Results

         9 files  ±0    1 077 suites  ±0   39m 32s ⏱️ + 1m 41s
  3 710 tests ±0    3 431 ✔️ ±0  279 💤 ±0  0 ±0 
15 826 runs  ±0  15 521 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit fb38ea0. ± Comparison against base commit 2199161.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Jul 28, 2023

Is this supported by ELs yet, or? These are generally most specifically useful when either they're required for an upcoming devnet or they show up in a consensus-spec/execution-api/etc release.

@henridf
Copy link
Contributor Author

henridf commented Jul 28, 2023

Is this supported by ELs yet, or? These are generally most specifically useful when either they're required for an upcoming devnet or they show up in a consensus-spec/execution-api/etc release.

EL support is in progress (from a quick look at the spec PR, I see erigon, nim-eth PR links to it).

Also this is slated for devnet8.

@tersec
Copy link
Contributor

tersec commented Jul 28, 2023

This shouldn't intrinsically break/interact with the consensus spec tests, so should be possible to update separately as required, though by then beta.1 probably will be out anyway, with its new tests

@tersec tersec marked this pull request as ready for review August 2, 2023 20:52
@tersec tersec merged commit 2819446 into status-im:unstable Aug 2, 2023
@henridf henridf deleted the rename-data-gas-blob-gas branch August 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants