-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customisation of preview generation #673
Conversation
If we take into account #672 isn't it more useful though if at least the start/end time exclusions are in the generate dialog/ task page as options and not in the config? |
Good idea. I'm thinking that we keep the existing settings in there which will be used as defaults, and allow the generate dialog to override them. Thoughts? |
It seems to work fine for me. The only thing that troubles me a bit is the cache usage . I tried force reloading in firefox/chrome to get the new overwritten preview instead of the old one with no success (preview file was generated/overwritten correctly). I had to use the dev tools in chrome and set the no-cache option to get the new preview to play. |
I've changed the preview response to include |
My main concern is people reporting that it doesn't work because they can't see the newly created preview. The no-cache should help though for the newly generated files. Imho it is good enough as it is now. |
* Add generate-specific options * Include no-cache in preview response
Alternative to #668
Provides an alternative solution to #634
Exposes a number of new settings for preview video generation:
2%
), default 0)