Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customisation of preview generation #673

Merged
merged 9 commits into from
Jul 23, 2020

Conversation

WithoutPants
Copy link
Collaborator

Alternative to #668

Provides an alternative solution to #634

Exposes a number of new settings for preview video generation:

  • number of segments (default 12)
  • duration per segment (default 0.75s)
  • exclusion start (expressed in seconds or a percentage of total duration (ie 2%), default 0)
  • exclusion end (as above)

image

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Jul 17, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Jul 17, 2020
@bnkai
Copy link
Collaborator

bnkai commented Jul 18, 2020

If we take into account #672 isn't it more useful though if at least the start/end time exclusions are in the generate dialog/ task page as options and not in the config?
For most use cases i would imagine that changing the default start/end shouldn't be applied to all newly scanned scenes but only to those that are grouped together by the user ( eg for a specific studio. Different studios usually have different length intros/endings ).

@WithoutPants
Copy link
Collaborator Author

Good idea. I'm thinking that we keep the existing settings in there which will be used as defaults, and allow the generate dialog to override them. Thoughts?

@WithoutPants
Copy link
Collaborator Author

Added Preview Options to the Generate dialog:

image
image

These values are filled in from the configuration settings so that the user can customise them appropriately.

@bnkai
Copy link
Collaborator

bnkai commented Jul 21, 2020

It seems to work fine for me.
The override option in the generate dialog looks great.

The only thing that troubles me a bit is the cache usage . I tried force reloading in firefox/chrome to get the new overwritten preview instead of the old one with no success (preview file was generated/overwritten correctly). I had to use the dev tools in chrome and set the no-cache option to get the new preview to play.

@WithoutPants
Copy link
Collaborator Author

I've changed the preview response to include no-cache in the header, but I think that this is a client-side issue and there's little we can do. Closing the tab and reopening does seem to fix the issue.

@bnkai
Copy link
Collaborator

bnkai commented Jul 22, 2020

My main concern is people reporting that it doesn't work because they can't see the newly created preview. The no-cache should help though for the newly generated files. Imho it is good enough as it is now.

@WithoutPants WithoutPants merged commit a2341f0 into stashapp:develop Jul 23, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add generate-specific options
* Include no-cache in preview response
@WithoutPants WithoutPants deleted the preview-settings branch February 4, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants