Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ability for previews to skip the intro of scenes from specific sources #634

Open
ConstantMoo opened this issue Jun 25, 2020 · 1 comment
Labels
feature Pull requests that add a new feature

Comments

@ConstantMoo
Copy link

Hi and thanks for this great project I discovered a few days ago. Here goes my first issue for it! :shipit:

Is your feature request related to a problem? Please describe.

When browsing in wall mode, scenes from sources such as Pornhub have 2-3 sec intros that don't need to be in the preview imho. For example, as of now, the first frame of my wall looks like this:

dfdfgf

Depending on the content, some studios and performers also have they own intro.

Describe the solution you'd like

  1. Not sure how the project is working and I never coded in Go, but my assumption would be to add an Intro Length (sec) field to Studio, Movie and Performer classes. Default value would be 0 which means there's no intro.

  2. Then, when a scene is linked to a studio/movie/performer, the user has the ability on the edit scene page to select either:

  • Studio intro length
  • Movie intro length
  • Performer intro length
  • A custom value in case the scene is specific
  1. Upon scene preview generation, the generation function would look for a intro length field value and if it's different than 0, the first frame would skip by the amount of the field value.
  • It would also be possible to set a preference order for which default intro length value to use when a scene is linked to more than one entity.

  • There's also the case when a scene is from a Studio that doesn't have an intro unless it's hosted on Pornhub. For these cases, we could add a Video Provider modifiable list somewhere in the admin panel with their name and the Intro Length value. This would be an additional option in the edit scene page.

Describe alternatives you've considered

I don't see alternatives beside transcoding my library of files containing such intros, which would take a while.

Additional context
N/A

@ConstantMoo ConstantMoo changed the title [Feature] Skip intro of scenes of specific sources [Feature] Ability for previews to skip the intro of scenes from specific sources Jun 25, 2020
@bnkai bnkai added the feature Pull requests that add a new feature label Jun 29, 2020
@rg9400
Copy link

rg9400 commented Jul 16, 2020

+1. I think the solution you described is a bit complex and manual. If we just blankety offset the first frame by a few seconds, is there any harm? Even scenes without intros wouldn't be impacted too much I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

No branches or pull requests

3 participants