LS: Look for unmanaged core in Scarb

[mkaput]

fixes #6235

---

This change is 

[orizi]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)

[Arcticae]

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Draggu and @piotmag769)

[orizi]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Draggu and @piotmag769)

[Draggu]

Reviewed 2 of 5 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @piotmag769)

[piotmag769]

feel free to resolve everything and answer later

Reviewed 2 of 5 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mkaput)

---

crates/cairo-lang-language-server/src/project/unmanaged_core_crate.rs line 37 at r3 (raw file):

        .or_else(|| find_scarb_managed_core(scarb))
        .or_else(|| {
            if cfg!(feature = "testing") {

Is this feature set by compiler team?

---

crates/cairo-lang-language-server/src/project/unmanaged_core_crate.rs line 133 at r3 (raw file):

    };

    static CACHE: OnceLock<Option<PathBuf>> = OnceLock::new();

Smart! 💡

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 56 at r3 (raw file):

                if path.is_none() {
                    if self.is_silent {
                        // If we are in silent mode, then missing Scarb is probably dealt with

Why?

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 83 at r3 (raw file):

                // initialized yet.
                //
                // This maintains a good UX for the following scenario (timeline):

Could you elaborate on that? I don't think I quite get it

[mkaput]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @piotmag769)

---

crates/cairo-lang-language-server/src/project/unmanaged_core_crate.rs line 37 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

Is this feature set by compiler team?

This is only set in our tests, here:

cairo/crates/cairo-lang-language-server/Cargo.toml

Line 43 in 536bcff

cairo-lang-language-server = { path = ".", features = ["testing"] }

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 56 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

Why?

The whole idea of silent mode is that we're using Scarb but in a not obligatory way, i.e. nothing's wrong if Scarb is missing etc. This naturally means that we cannot shout at the user like we'd do in normal mode because this might end up being misleading.

A prime example are the E2E tests, where we don't have Scarb, so we expect the scarb-managed-core branch to fail, but right after we're using detect_corelib. We do not want to produce the missing-scarb notification in such scenario.

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 83 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

Could you elaborate on that? I don't think I quite get it

A silently failing scarb-managed-core flow that would happen before scarb metadata call, could block the missing-scarb notificaiton from popping up when that scarb metadata is run

[piotmag769]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)