LS: Consider empty strings in workspace/configuration as None

[mkaput]

It occurs that the workspace/configuration
request returns Some("") for the cairo1.corelibPath
field even if it is not set anywhere.
This fact blocked any logic that happened in the find_unmanaged_core
function,
as it always assumed
that the user explicitly set the path in their config to "".
By nullifying empty configuration values, this change fixes
find_unmanaged_core.

---

Stack:

• LS: Look for unmanaged core in Scarb #6248
• LS: Consider empty strings in workspace/configuration as None #6247 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @piotmag769)

---

crates/cairo-lang-language-server/src/config.rs line 83 at r1 (raw file):

fn nullify_empty_str(value: &str) -> Option<&str> {
    (!value.is_empty()).then_some(value)
}

Suggestion:

            self.unmanaged_core_path = response
                .pop_front()
                .as_ref()
                .and_then(Value::as_str)
                .filter(|v|!v.is_empty())
                .map(Into::into);

            debug!("reloaded configuration: {self:#?}");
        }
    }
}

[mkaput]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/config.rs line 83 at r1 (raw file):

fn nullify_empty_str(value: &str) -> Option<&str> {
    (!value.is_empty()).then_some(value)
}

🧠

Done

[Draggu]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @orizi, and @piotmag769)

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @piotmag769)

[piotmag769]

returns Some("") for the cairo1.corelibPath

Do you know why this happens? Isn't it an issue with our extension? Does it happen for other fields that are strings as well?

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[mkaput]

I tried to find a reason but couldn't conclude anything in reasonable time.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[Arcticae]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)