Added warnings for bad embeddable impls. #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2024
orizi
force-pushed
the
pr/orizi/release-prep/48280088
branch
from
ce943c0 to
d0cb517
Compare
orizi
force-pushed
the
pr/orizi/release-prep/83a29e99
branch
from
3a885b3 to
04c3ba5
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/src/analyzer.rs line 44 at r1 (raw file):
diagnostics.push(PluginDiagnostic::warning( item.stable_ptr().untyped(), "impls with the embeddable attribute must implement a starknet interface trait."
Suggestion:
Impls with the embeddable
commit-id:48280088
orizi
force-pushed
the
pr/orizi/release-prep/48280088
branch
from
d0cb517 to
5d29b8b
Compare
orizi
commented
Jan 15, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
gilbens-starkware
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
embeddable_asdiagnostics. #4797This change is