Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Serde, Store, PartialEq, Debug and Display for NonZero. #4795

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 14, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@orizi orizi linked an issue Jan 14, 2024 that may be closed by this pull request
2 tasks
@orizi orizi force-pushed the pr/orizi/release-prep/83a29e99 branch from 057685a to 3a885b3 Compare January 14, 2024 15:49
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/starknet/storage_access.cairo line 277 at r1 (raw file):

    #[inline]
    fn unpack(value: T) -> NonZero<T> {
        value.try_into().expect('StoreNonZero - non zero value')

Or non NonZero value.

Suggestion:

zero value

@orizi orizi force-pushed the pr/orizi/release-prep/83a29e99 branch from 3a885b3 to 04c3ba5 Compare January 15, 2024 10:07
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi enabled auto-merge January 15, 2024 10:10
@orizi orizi added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 1f29ddb Jan 15, 2024
84 checks passed
@orizi orizi deleted the pr/orizi/release-prep/83a29e99 branch January 22, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Serde on NonZero
2 participants