Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StorageValue for tuples up to size 4. #3674

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 13, 2023

This change is Reviewable

@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/2bc7c6a6 branch from 3d6f564 to f50546e Compare July 13, 2023 09:34
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/f17bf431 branch from bd277d9 to 578311c Compare July 13, 2023 09:34
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)


corelib/src/starknet/storage_access.cairo line 491 at r1 (raw file):

    ) -> SyscallResult<(E0, E1)> {
        let e0 = E0StorageValue::read_at_offset(address_domain, base, offset)?;
        let offset = E0StorageValue::size();

Same below.

Suggestion:

let offset = offset + E0StorageValue::size();

corelib/src/starknet/storage_access.cairo line 548 at r1 (raw file):

        let offset = E0StorageValue::size();
        let e1 = E1StorageValue::read_at_offset(address_domain, base, offset)?;
        let offset = offset + E1StorageValue::size();

Suggestion:

        let mut offset = offset + E0StorageValue::size();
        let e1 = E1StorageValue::read_at_offset(address_domain, base, offset)?;
        offset += E1StorageValue::size();

@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/2bc7c6a6 branch from f50546e to 37230af Compare July 13, 2023 10:24
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/f17bf431 branch from 578311c to 0b722de Compare July 13, 2023 10:24
@orizi orizi changed the base branch from pr/orizi/orizi/storage-access-updates/f17bf431 to main July 13, 2023 10:47
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/2bc7c6a6 branch from 37230af to d99a127 Compare July 13, 2023 10:47
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @spapinistarkware)


corelib/src/starknet/storage_access.cairo line 491 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Same below.

Done.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@orizi orizi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit c74cbe8 Jul 13, 2023
@orizi orizi deleted the pr/orizi/orizi/storage-access-updates/2bc7c6a6 branch July 16, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants