-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added StorageValue for tuples up to size 4. #3674
Conversation
3d6f564
to
f50546e
Compare
bd277d9
to
578311c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)
corelib/src/starknet/storage_access.cairo
line 491 at r1 (raw file):
) -> SyscallResult<(E0, E1)> { let e0 = E0StorageValue::read_at_offset(address_domain, base, offset)?; let offset = E0StorageValue::size();
Same below.
Suggestion:
let offset = offset + E0StorageValue::size();
corelib/src/starknet/storage_access.cairo
line 548 at r1 (raw file):
let offset = E0StorageValue::size(); let e1 = E1StorageValue::read_at_offset(address_domain, base, offset)?; let offset = offset + E1StorageValue::size();
Suggestion:
let mut offset = offset + E0StorageValue::size();
let e1 = E1StorageValue::read_at_offset(address_domain, base, offset)?;
offset += E1StorageValue::size();
f50546e
to
37230af
Compare
578311c
to
0b722de
Compare
commit-id:2bc7c6a6
37230af
to
d99a127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @spapinistarkware)
corelib/src/starknet/storage_access.cairo
line 491 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Same below.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
This change is