Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made StorageAccess trait somewhat cleaner. #3671

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Made StorageAccess trait somewhat cleaner. #3671

merged 1 commit into from
Jul 13, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 13, 2023 •
edited by spapinistarkware
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

@orizi orizi mentioned this pull request Jul 13, 2023
Merged
gilbens-starkware
gilbens-starkware approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@orizi orizi mentioned this pull request Jul 13, 2023
Merged
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/ea15b218 branch from ec66be7 to a4ef742 Compare July 13, 2023 08:39
gilbens-starkware
gilbens-starkware approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@orizi orizi mentioned this pull request Jul 13, 2023
Merged
@orizi orizi force-pushed the pr/orizi/orizi/storage-access-updates/ea15b218 branch from a4ef742 to 771c8c1 Compare July 13, 2023 09:05
@orizi orizi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit d8da820 Jul 13, 2023
@milancermak
Copy link
Contributor

Are there any more plans to modify the StorageAccess / StorageValue trait?

orizi
orizi commented Jul 13, 2023
View reviewed changes
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully not any time soon - we have some additional suggestion on how to make this generally work better, but this is already a good step in the right direction.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@orizi orizi deleted the pr/orizi/orizi/storage-access-updates/ea15b218 branch July 16, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

@spapinistarkware spapinistarkware Awaiting requested review from spapinistarkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orizi @milancermak @gilbens-starkware