Fix issue with recompiling stan code #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I have backported the changes from stan-dev/stanc3#1074 into a 2.26 branch here. This PR changes the built stancjs to this version, which resolves an issue where subsequent calls to stancjs did not clean up prior inputs correctly.
This closes #982
Intended Effect:
Subsequent calls to stancjs should work even if earlier calls failed.
How to Verify:
Code provided by @andrjohns. Both calls fail on the current 2.26 version, only the first fails in this branch.
Side Effects:
None
Documentation:
N/A
Reviewer Suggestions:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: