Backport stanc3 bugfix for ternary ops with expressions #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrjohns I'll need a release out of this to ship the JS in RStan. |
|
You may test it with the latest version of RStan v2.26. |
|
No rush on shipping a new version just yet, I'm still working through other revdep failures for rstan 2.26 so there might be other patches still to come |
hsbadr
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsbadr
This PR updates the
stanc.jsfile to backport the bugfix from stan-dev/stanc3#977 for handling ternary operations with Eigen expressions. This will be needed for themultinmapackage.I used the same stanc3 branch previously used for backporting stanc3 patches in #988