fix: No more array-of-array return in ApiComponentStatus #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the `ApiComponentStatus` class in `routes.py` to return the cached component if it exists, instead of wrapping it in a list. This improves the efficiency of the API by avoiding unnecessary list creation.
Aloento
requested review from
vladimirvshivkov,
vladimirhasko,
bakhterets and
anton-sidelnikov
bakhterets
approved these changes
Jun 5, 2024
|
Build succeeded. ✔️ otc-tox-docs SUCCESS in 3m 09s |
vladimirhasko
added a commit
to opentelekomcloud-infra/stackmon-config
that referenced
this pull request
Jun 19, 2024
timestamp standardization: stackmon/status-dashboard#121 API fix stackmon/status-dashboard#122
otc-zuul bot
pushed a commit
to opentelekomcloud-infra/stackmon-config
that referenced
this pull request
Jul 10, 2024
Update Status Dashboard to latest version timestamp standardization: stackmon/status-dashboard#121 API fix stackmon/status-dashboard#122 Reviewed-by: Aloento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the
ApiComponentStatusclass inroutes.pyto return instead of wrapping it in a list. This improves the efficiency of the API by avoiding unnecessary list creation.from
to