issue_105 #121
Merged
issue_105 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aloento
approved these changes
Jun 7, 2024
Aloento
previously approved these changes
Jun 7, 2024
app/datetime.py
Outdated
| return datetime.now(timezone.utc) | ||
|
|
||
|
|
||
| def utc_from_timestamp(timestamp): |
There was a problem hiding this comment.
this method has no usage anywhere, or it's just for future use?
There was a problem hiding this comment.
just for future use, can be deleted now
| start_date: Mapped[datetime.datetime] = mapped_column( | ||
| insert_default=func.now() | ||
| start_date: Mapped[datetime] = mapped_column( | ||
| db.DateTime, |
There was a problem hiding this comment.
is db.DateTime corect here? Before you used only one argument and now two
There was a problem hiding this comment.
this is an explicit indication of the data type
|
recheck |
vladimirhasko
approved these changes
Jun 17, 2024
|
Build succeeded. ✔️ otc-tox-docs SUCCESS in 3m 07s |
vladimirhasko
added a commit
to opentelekomcloud-infra/stackmon-config
that referenced
this pull request
Jun 19, 2024
timestamp standardization: stackmon/status-dashboard#121 API fix stackmon/status-dashboard#122
otc-zuul bot
pushed a commit
to opentelekomcloud-infra/stackmon-config
that referenced
this pull request
Jul 10, 2024
Update Status Dashboard to latest version timestamp standardization: stackmon/status-dashboard#121 API fix stackmon/status-dashboard#122 Reviewed-by: Aloento
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#105
Problem:
datetime: datetime.datetime’s utcnow() and utcfromtimestamp() are deprecated and will be removed in a future version. Instead, use timezone-aware objects to represent datetimes in UTC: respectively, call now() and fromtimestamp() with the tz parameter set to datetime.UTC. (Contributed by Paul Ganssle in gh-103857.)
Solution:
To add new function to get actual datetime_now with timezone and remove timezone to save the datebase models unchanged (to use postgresql and sqlite).
Conclusion:
All timestamps converts to utc timezone and stores without timezone in the database